Date: Fri, 20 Mar 2009 14:19:35 -0400 From: Coleman Kane <cokane@FreeBSD.org> To: Sam Leffler <sam@freebsd.org> Cc: svn-src-head@freebsd.org, Vasil Dimov <vd@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189828 - in head: include sys/sys Message-ID: <1237573175.1993.19.camel@localhost> In-Reply-To: <49C3D518.6070105@freebsd.org> References: <200903142010.n2EKAESF006945@svn.freebsd.org> <20090320140015.GA17645@hub.freebsd.org> <20090320153405.GA62675@zim.MIT.EDU> <49C3BCD4.4030605@freebsd.org> <1237567495.1993.2.camel@localhost> <49C3D518.6070105@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-pMvLpvf7zNpuZdBfNYIa Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2009-03-20 at 10:40 -0700, Sam Leffler wrote: > Coleman Kane wrote: > > On Fri, 2009-03-20 at 08:57 -0700, Sam Leffler wrote: > > =20 > >> David Schultz wrote: > >> =20 > >>> On Fri, Mar 20, 2009, Vasil Dimov wrote: > >>> =20 > >>> =20 > >>>> On Sat, Mar 14, 2009 at 08:10:14PM +0000, David Schultz wrote: > >>>> =20 > >>>> =20 > >>>>> Author: das > >>>>> Date: Sat Mar 14 20:10:14 2009 > >>>>> New Revision: 189828 > >>>>> URL: http://svn.freebsd.org/changeset/base/189828 > >>>>> > >>>>> Log: > >>>>> Fix the visibility of several prototypes. Also move pthread_kill(= ) and > >>>>> pthread_sigmask() to signal.h. In principle, this shouldn't break= anything, > >>>>> =20 > >>>>> =20 > >>>> [...] > >>>> > >>>> But it did break, see http://www.freebsd.org/cgi/query-pr.cgi?pr=3D1= 32828 > >>>> > >>>> I think one's namespace shouldn't be polluted with the prototype of > >>>> pthread_kill() if he has not included pthread.h. > >>>> =20 > >>>> =20 > >>> The pthreads API has always defined pthread_kill() to be in > >>> signal.h, not pthread.h. This is what is done in glibc and > >>> elsewhere. > >>> > >>> GNU Pth has some bogus and extremely unportable hacks to ``trick'' > >>> system headers into not declaring symbols: > >>> > >>> /* > >>> * Prevent system includes from implicitly including > >>> * possibly existing vendor Pthread headers > >>> */ > >>> #define PTHREAD > >>> #define PTHREAD_H > >>> #define _PTHREAD_T > >>> #define _PTHREAD_H > >>> #define _PTHREAD_H_ > >>> #define PTHREAD_INCLUDED > >>> #define _PTHREAD_INCLUDED > >>> #define SYS_PTHREAD_H > >>> #define _SYS_PTHREAD_H > >>> #define _SYS_PTHREAD_H_ > >>> #define SYS_PTHREAD_INCLUDED > >>> #define _SYS_PTHREAD_INCLUDED > >>> #define BITS_PTHREADTYPES_H > >>> #define _BITS_PTHREADTYPES_H > >>> #define _BITS_PTHREADTYPES_H_ > >>> #define _BITS_SIGTHREAD_H > >>> > >>> The one that works for glibc is _BITS_SIGTHREAD_H. I'd rather not > >>> be complicit in these shenanigans, but if we can't easily fix the > >>> problem in Pth, I suppose we can teach signal.h about one of these > >>> bogus macros. What do you think? > >>> > >>> =20 > >>> =20 > >> Dumb question, why do we need devel/pth? Isn't the native pthread=20 > >> support sufficient? > >> > >> Sam > >> > >> =20 > > > > For whatever reason, both security/libassuan and security/gnupg want > > pth. > > > > I was able to solve the problem by removing the "#include <signal.h>" > > from the offending file (there is only one) in devel/pth. After that, i= t > > built fine and I am using it now. > > > > Maybe devel/pth doesn't even really need to #include <signal.h> > > anymore.... > > =20 >=20 > Well a recent foray into dealing with this ports breakage made me=20 > question why we drag in various packages. devel/pth is one example; I=20 > see many others scroll by that appear to duplicate functionality in the=20 > base system. At the end of the day it's clearly an issue of maintenance=20 > overhead--we'd have to mod apps to do things like remove use of=20 > gnu-long-opts in to switch away from things like gtar and the savings is=20 > unclear. But I can ask... >=20 > Sam >=20 I've found that many of the GNU apps are notorious for this. I really can't say that I know why libassuan or gnupg explicitly require GNU pth, rather than first attempting to use POSIX pthread API. Their configure scripts both want to search for and run pth-config, and fail to enable some sort of threaded features if it doesn't exist. I already tried removing pth stuff from both port Makefiles to see what would happen. I didn't spend much time on it after I figured out that devel/pth would just work if I removed the signal.h include. I am guessing that some non-standard extensions which GNU pth provides are not provided by the normal POSIX spec. In fact, libassuan just goes ahead and uses a bunch of pth_* overrides for dealing with them in a thread-safe manner (waitpid, read, write, select, usleep). According to GnuPG (security/gnupg in the configure.ac file): *** To support concurrent access to the gpg-agent and the SCdaemon *** we need the support of the GNU Portable Threads Library. *** Download it from ftp://ftp.gnu.org/gnu/pth/ *** On a Debian GNU/Linux system you might want to try *** apt-get install libpth-dev --=20 Coleman Kane --=-pMvLpvf7zNpuZdBfNYIa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEUEABECAAYFAknD3jcACgkQcMSxQcXat5e7/gCcDlgCxULcbgTEj2q89CbRChlu WiwAmJteH+rbT4/avhddMACqM4YFlcI= =6CFn -----END PGP SIGNATURE----- --=-pMvLpvf7zNpuZdBfNYIa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1237573175.1993.19.camel>