Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Jul 2006 01:51:15 GMT
From:      John Birrell <jb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 100590 for review
Message-ID:  <200607050151.k651pFnV033262@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=100590

Change 100590 by jb@jb_freebsd2 on 2006/07/05 01:51:05

	A few kse bits that didn't seem to get updated with the bike_sched
	integration.

Affected files ...

.. //depot/projects/dtrace/src/lib/libkvm/kvm_proc.c#3 edit
.. //depot/projects/dtrace/src/sys/ddb/db_ps.c#5 edit
.. //depot/projects/dtrace/src/usr.bin/kdump/kdump.c#4 edit

Differences ...

==== //depot/projects/dtrace/src/lib/libkvm/kvm_proc.c#3 (text+ko) ====

@@ -114,7 +114,7 @@
 	struct prison pr;
 	struct thread mtd;
 	/*struct kse mke;*/
-	struct ksegrp mkg;
+	/*struct ksegrp mkg;*/
 	struct proc proc;
 	struct proc pproc;
 	struct timeval tv;
@@ -137,6 +137,7 @@
 				    TAILQ_FIRST(&proc.p_threads));
 				return (-1);
 			}
+#if 0
 			if ((proc.p_flag & P_SA) == 0) {
 				if (KREAD(kd,
 				    (u_long)TAILQ_FIRST(&proc.p_ksegrps),
@@ -146,7 +147,6 @@
 					    TAILQ_FIRST(&proc.p_ksegrps));
 					return (-1);
 				}
-#if 0
 				if (KREAD(kd,
 				    (u_long)TAILQ_FIRST(&mkg.kg_kseq), &mke)) {
 					_kvm_err(kd, kd->program,
@@ -154,8 +154,8 @@
 					    TAILQ_FIRST(&mkg.kg_kseq));
 					return (-1);
 				}
+			}
 #endif
-			}
 		}
 		if (KREAD(kd, (u_long)proc.p_ucred, &ucred) == 0) {
 			kp->ki_ruid = ucred.cr_ruid;
@@ -418,13 +418,13 @@
 			kp->ki_oncpu = mtd.td_oncpu;
 
 			if (!(proc.p_flag & P_SA)) {
+#if 0
 				/* stuff from the ksegrp */
 				kp->ki_slptime = mkg.kg_slptime;
 				kp->ki_pri.pri_class = mkg.kg_pri_class;
 				kp->ki_pri.pri_user = mkg.kg_user_pri;
 				kp->ki_estcpu = mkg.kg_estcpu;
 
-#if 0
 				/* Stuff from the kse */
 				kp->ki_pctcpu = mke.ke_pctcpu;
 				kp->ki_rqindex = mke.ke_rqindex;

==== //depot/projects/dtrace/src/sys/ddb/db_ps.c#5 (text+ko) ====

@@ -294,8 +294,7 @@
 		td = kdb_thread;
 
 	db_printf("Thread %d at %p:\n", td->td_tid, td);
-	db_printf(" proc (pid %d): %p ", td->td_proc->p_pid, td->td_proc);
-	db_printf(" ksegrp: %p\n", td->td_ksegrp);
+	db_printf(" proc (pid %d): %p\n", td->td_proc->p_pid, td->td_proc);
 	if (td->td_name[0] != '\0')
 		db_printf(" name: %s\n", td->td_name);
 	db_printf(" flags: %#x ", td->td_flags);

==== //depot/projects/dtrace/src/usr.bin/kdump/kdump.c#4 (text+ko) ====

@@ -728,12 +728,6 @@
 				mountflagsname ((int)*ip);
 				ip++;
 				narg--;
-			} else if (ktr->ktr_code == SYS_kse_thr_interrupt) {
-				print_number(ip,narg,c);
-				(void)putchar(',');
-				ksethrcmdname ((int)*ip);
-				ip++;
-				narg--;
 			} else if (ktr->ktr_code == SYS_thr_create) {
 				print_number(ip,narg,c);
 				print_number(ip,narg,c);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607050151.k651pFnV033262>