Date: Sat, 12 Oct 2013 15:21:03 +0000 From: "Teske, Devin" <Devin.Teske@fisglobal.com> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "Teske, Devin" <Devin.Teske@fisglobal.com>, Nathan Whitehorn <nwhitehorn@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Devin Teske <dteske@FreeBSD.org> Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts Message-ID: <13CA24D6AB415D428143D44749F57D720FC5B8F1@LTCFISWMSGMB21.FNFIS.com> In-Reply-To: <86txgmr0oh.fsf@nine.des.no> References: <201310112041.r9BKfZeT002056@svn.freebsd.org> <5258F9B3.7030101@freebsd.org> <13CA24D6AB415D428143D44749F57D720FC5B547@LTCFISWMSGMB21.FNFIS.com> <86txgmr0oh.fsf@nine.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 12, 2013, at 8:03 AM, Dag-Erling Sm=F8rgrav wrote: > "Teske, Devin" <Devin.Teske@fisglobal.com> writes: >> The code to replace the use of camcontrol is a a *very* complex parsing >> of the geom XML configuration data stashed in sysctl. jmg@ started the >> ball rolling on that. >=20 > You realize there is a text version as well? >=20 >> Yes. Which has been discussed at-length, you didn't need to put a >> sandbag on my back (publicly no less; thanks for that). >=20 > Umm, I think Nathan was pretty civil. You're the one who's turning this > into a catfight. >=20 Reflecting upon the thread to see if you're _right_... 1. He stated there were still some issues. [definitely civil] 2. "I am surprised you committed it especially to stable/10, before those issues were resolved." [civil? or inflammatory?] 3. "I'm also not sure if people can review their own patches." [misundersta= nding] 4. "Installer regressions are very easy to introduce and very problematic when created." [statements like that invariably lead people to believe he v= iews the commit as a regression -- I explained in a follow-up that it is not a r= egression] 5. "Real review for installer changes is thus especially important this lat= e in the release cycle." [I read this invariably as he views that the commit did not= go through "Real review", but again... there is no regression and it's purely = value- add] 6. "Do you have any plans to fix these issues in the very near future?" [de= finitely civil] What got me ralled up was #'s 2, 4, and 5. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13CA24D6AB415D428143D44749F57D720FC5B8F1>