Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 May 2018 00:56:41 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r333234 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Message-ID:  <201805040056.w440ufvq034086@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Fri May  4 00:56:41 2018
New Revision: 333234
URL: https://svnweb.freebsd.org/changeset/base/333234

Log:
  zfs_ioctl: avoid out-of-bound read
  
  admbugs:	796
  Submitted by:	Domagoj Stolfa <ds815@cam.ac.uk>
  Reported by:	Ilja Van Sprundel <ivansprundel@ioactive.com>
  Reviewed by:	avg
  MFC after:	1 day

Modified:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c

Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
==============================================================================
--- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c	Fri May  4 00:34:27 2018	(r333233)
+++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c	Fri May  4 00:56:41 2018	(r333234)
@@ -6440,6 +6440,10 @@ zfsdev_ioctl(struct cdev *dev, u_long zcmd, caddr_t ar
 			cflag = ZFS_CMD_COMPAT_V28;
 			break;
 		case sizeof(zfs_cmd_v15_t):
+			if (cmd >= sizeof(zfs_ioctl_v15_to_v28) /
+			    sizeof(zfs_ioctl_v15_to_v28[0]))
+				return (EINVAL);
+
 			cflag = ZFS_CMD_COMPAT_V15;
 			vecnum = zfs_ioctl_v15_to_v28[cmd];
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805040056.w440ufvq034086>