Date: Wed, 9 Oct 2002 11:45:44 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: current@freebsd.org Subject: Re: alpha tinderbox failure Message-ID: <Pine.BSF.4.21.0210091139120.14413-100000@root.org> In-Reply-To: <15780.18620.457682.641298@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 9 Oct 2002, Andrew Gallatin wrote: > Jeff Roberson writes: > > > > On Tue, 8 Oct 2002, Dag-Erling Smorgrav wrote: > > > "Makefile", line 4194: warning: duplicate script for target "geom_bsd.o" ignored > > > cc1: warnings being treated as errors > > > /h/des/src/sys/dev/advansys/adv_pci.c: In function `adv_pci_attach': > > > /h/des/src/sys/dev/advansys/adv_pci.c:197: warning: overflow in implicit constant conversion > > > *** Error code 1 > > > > Any progress on this? > > This particular message is caused by alpha's > > #define BUS_SPACE_UNRESTRICTED (~0UL) > > Clashing with int nsegments: > > Sparc64 has the same problem. ia64 gets around it by just making > BUS_SPACE_UNRESTRICTED an int: > > #define BUS_SPACE_UNRESTRICTED (~0) > > I'd like to do the same for alpha. I think this is valid, as > BUS_SPACE_UNRESTRICTED seems to be used exlusively as an argument > to bus_dma_tag_create(... nsegments = BUS_SPACE_UNRESTRICTED...) Yes, I looked into this before and agree this is a valid approach. It's likely the number of segments never exceeds 32, let alone 2^31. > I'd also like to add a bus_space_subregion(). Please review the > appended patch. I'm running it with no ill effects, and it makes > alpha get a bit further on in LINT. (until it dies on printf format > warnings). Its going to be a bear to get a clean lint with Werror. > All those crusty old isa drivers casting pointers to integers make > me feel a bit overwhelmed. I can spend a little time cleaning that up as things progress. The patch looks fine. > It would be nice if des could remove LINT from the tinderbox builds > until LINT has a chance of compiling. Right now people are ignoring > the alpha tinderbox failure messages. Eventually, it will fail for a > reason besides useless LINT garbage, and everybody will ignore it. Ok by me. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0210091139120.14413-100000>