Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 Nov 2013 13:14:46 +0000 (UTC)
From:      Jean-Sebastien Pedron <dumbbell@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r257544 - user/ed/newcons/sys/dev/drm2
Message-ID:  <201311021314.rA2DEkmn082355@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dumbbell
Date: Sat Nov  2 13:14:46 2013
New Revision: 257544
URL: http://svnweb.freebsd.org/changeset/base/257544

Log:
  drm: Log error if we fail to attach fbd device

Modified:
  user/ed/newcons/sys/dev/drm2/drm_fb_helper.c

Modified: user/ed/newcons/sys/dev/drm2/drm_fb_helper.c
==============================================================================
--- user/ed/newcons/sys/dev/drm2/drm_fb_helper.c	Sat Nov  2 11:37:16 2013	(r257543)
+++ user/ed/newcons/sys/dev/drm2/drm_fb_helper.c	Sat Nov  2 13:14:46 2013	(r257544)
@@ -1034,9 +1034,14 @@ int drm_fb_helper_single_fb_probe(struct
 
 #if defined(__FreeBSD__)
 	if (new_fb) {
+		device_t fbd;
+		int ret;
+
 		kdev = fb_helper->dev->device;
-		device_add_child(kdev, "fbd", device_get_unit(kdev));
-		bus_generic_attach(kdev);
+		fbd = device_add_child(kdev, "fbd", device_get_unit(kdev));
+		ret = device_probe_and_attach(fbd);
+		if (ret != 0)
+			DRM_ERROR("Failed to attach fbd device: %d\n", ret);
 	}
 #else
 	if (new_fb) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311021314.rA2DEkmn082355>