Date: Sat, 3 Dec 2011 14:00:25 GMT From: Alexander Best <arundel@freebsd.org> To: freebsd-wireless@FreeBSD.org Subject: Re: kern/162475: [ath] functions with return type HAL_BOOL (might) return HAL_STATUS Message-ID: <201112031400.pB3E0PfU001105@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/162475; it has been noted by GNATS.
From: Alexander Best <arundel@freebsd.org>
To: bug-followup@freebsd.org
Cc:
Subject: Re: kern/162475: [ath] functions with return type HAL_BOOL (might) return HAL_STATUS
Date: Sat, 3 Dec 2011 13:55:34 +0000
here are two more examples:
/usr/subversion-src/sys/dev/an/if_an.c:800:41: warning: implicit conversion from enumeration type 'enum ieee80211_phytype' to different enumeration type 'enum ieee80211_phymode' [-Wconversion]
mword = ieee80211_rate2media(NULL, r, IEEE80211_T_DS);
~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~
/usr/subversion-src/sys/dev/an/if_an.c:3302:30: warning: implicit conversion from enumeration type 'enum ieee80211_phytype' to different enumeration type 'enum ieee80211_phymode' [-Wconversion]
status.an_current_tx_rate, IEEE80211_T_DS);
^~~~~~~~~~~~~~
2 warnings generated.
..also fixing these would make the entire kernel code "-Wconversion"-clean, i believe.
cheers.
alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112031400.pB3E0PfU001105>