Date: Sun, 15 Jun 2008 21:37:18 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Andrey Chernov <ache@nagual.pp.ru>, K?vesd?n G?bor <gabor@t-hosting.hu>, Diomidis Spinellis <dds@aueb.gr>, hackers@freebsd.org, Doug Barton <dougb@freebsd.org>, current@freebsd.org, "Sean C. Farley" <scf@freebsd.org>, Max Khon <fjoe@samodelkin.net> Subject: Re: CFT: BSD-licensed grep [Fwd: cvs commit: ports/textproc/bsdgrep Makefile distinfo] Message-ID: <4855EDFE.3010708@FreeBSD.org> In-Reply-To: <20080615212613.GA97326@nagual.pp.ru> References: <485453F2.60507@FreeBSD.org> <4854BC29.3060507@FreeBSD.org> <4854C96A.1080603@aueb.gr> <48556AAD.9010602@t-hosting.hu> <20080615212613.GA97326@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrey Chernov wrote:
> On Sun, Jun 15, 2008 at 09:17:01PM +0200, K?vesd?n G?bor wrote:
>> Yes, of course, I haven't forgotten about your suggestion. First, I'd
>> like to process the trivial errors, which come up like this one and make
>> some tests myself. Then I'll think about this idea and ask portmgr to do
>> an exp-run with BSD grep.
I think that would be very valuable.
> Please note that BSD grep is not localized (and can't be per design) and
> works only with standard C locale. It may not affect ports system
> processing but shurely affects real texts handling.
That is very troubling. In this day and age localization is a
requirement. I cannot imagine being supportive of adding something to
the base that does not have this capability.
I also found another gratuitous difference in behavior tonight, again
from portmaster (which uses grep a LOT, which is why I thought to try
it out in the first place). I do this type of thing in lots of places:
pkg=/var/db/pkg/p5-Net-DNS-0.63
if grep -ql '^@pkgdep ' $pkg/+CONTENTS 2>/dev/null; then
<do something>
fi
With gnu grep I get no output, and if there is a match the if
statement just runs as I'd expect. With bsd grep I'm getting the name
of the file as output.
That's 3 strikes and you're out as far as I'm concerned. I think this
project needs to come a lot closer to feature compatibility with gnu
grep (including the ability to be localized) before it's ready for a
wider audience. Of course, that's just my opinion.
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4855EDFE.3010708>