Date: Fri, 31 May 2013 17:23:38 +0000 (UTC) From: Jung-uk Kim <jkim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r251186 - head/usr.sbin/acpi/acpidump Message-ID: <201305311723.r4VHNcif087353@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jkim Date: Fri May 31 17:23:38 2013 New Revision: 251186 URL: http://svnweb.freebsd.org/changeset/base/251186 Log: Fix a long standing logic bug introduced in r167814. The code was added to get RSDP from loader(8) hint via kenv(2) but the bug nullified the new code and we always fell back to the previous method, i. e., sysctlbyname(3). MFC after: 3 days Modified: head/usr.sbin/acpi/acpidump/acpi_user.c Modified: head/usr.sbin/acpi/acpidump/acpi_user.c ============================================================================== --- head/usr.sbin/acpi/acpidump/acpi_user.c Fri May 31 17:01:53 2013 (r251185) +++ head/usr.sbin/acpi/acpidump/acpi_user.c Fri May 31 17:23:38 2013 (r251186) @@ -172,7 +172,7 @@ acpi_find_rsd_ptr(void) addr = 0; /* Attempt to use kenv or sysctl to find RSD PTR record. */ - if (kenv(KENV_GET, hint_acpi_0_rsdp, buf, 20) == 0) + if (kenv(KENV_GET, hint_acpi_0_rsdp, buf, 20) > 0) addr = strtoul(buf, NULL, 0); if (addr == 0) { len = sizeof(addr);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305311723.r4VHNcif087353>