Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 May 2018 15:47:42 +0000 (UTC)
From:      Marius Strobl <marius@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r333215 - stable/11/sys/dev/e1000
Message-ID:  <201805031547.w43Flg10048667@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marius
Date: Thu May  3 15:47:42 2018
New Revision: 333215
URL: https://svnweb.freebsd.org/changeset/base/333215

Log:
  MFC: r330803
  
  Use FALLTHROUGH.

Modified:
  stable/11/sys/dev/e1000/e1000_82575.c
  stable/11/sys/dev/e1000/e1000_mbx.c
  stable/11/sys/dev/e1000/e1000_phy.c
  stable/11/sys/dev/e1000/e1000_vf.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/e1000/e1000_82575.c
==============================================================================
--- stable/11/sys/dev/e1000/e1000_82575.c	Thu May  3 15:41:04 2018	(r333214)
+++ stable/11/sys/dev/e1000/e1000_82575.c	Thu May  3 15:47:42 2018	(r333215)
@@ -1678,7 +1678,7 @@ static s32 e1000_setup_serdes_link_82575(struct e1000_
 	case E1000_CTRL_EXT_LINK_MODE_1000BASE_KX:
 		/* disable PCS autoneg and support parallel detect only */
 		pcs_autoneg = FALSE;
-		/* fall through to default case */
+		/* FALLTHROUGH */
 	default:
 		if (hw->mac.type == e1000_82575 ||
 		    hw->mac.type == e1000_82576) {
@@ -1805,6 +1805,7 @@ static s32 e1000_get_media_type_82575(struct e1000_hw 
 			break;
 		}
 		/* fall through for I2C based SGMII */
+		/* FALLTHROUGH */
 	case E1000_CTRL_EXT_LINK_MODE_PCIE_SERDES:
 		/* read media type from SFP EEPROM */
 		ret_val = e1000_set_sfp_media_type_82575(hw);

Modified: stable/11/sys/dev/e1000/e1000_mbx.c
==============================================================================
--- stable/11/sys/dev/e1000/e1000_mbx.c	Thu May  3 15:41:04 2018	(r333214)
+++ stable/11/sys/dev/e1000/e1000_mbx.c	Thu May  3 15:47:42 2018	(r333215)
@@ -778,6 +778,7 @@ s32 e1000_init_mbx_params_pf(struct e1000_hw *hw)
 		mbx->stats.reqs = 0;
 		mbx->stats.acks = 0;
 		mbx->stats.rsts = 0;
+		/* FALLTHROUGH */
 	default:
 		return E1000_SUCCESS;
 	}

Modified: stable/11/sys/dev/e1000/e1000_phy.c
==============================================================================
--- stable/11/sys/dev/e1000/e1000_phy.c	Thu May  3 15:41:04 2018	(r333214)
+++ stable/11/sys/dev/e1000/e1000_phy.c	Thu May  3 15:47:42 2018	(r333215)
@@ -1297,6 +1297,7 @@ s32 e1000_copper_link_setup_m88_gen2(struct e1000_hw *
 			phy_data |= M88E1000_PSCR_AUTO_X_1000T;
 			break;
 		}
+		/* FALLTHROUGH */
 	case 0:
 	default:
 		phy_data |= M88E1000_PSCR_AUTO_X_MODE;

Modified: stable/11/sys/dev/e1000/e1000_vf.c
==============================================================================
--- stable/11/sys/dev/e1000/e1000_vf.c	Thu May  3 15:41:04 2018	(r333214)
+++ stable/11/sys/dev/e1000/e1000_vf.c	Thu May  3 15:47:42 2018	(r333215)
@@ -487,8 +487,10 @@ s32 e1000_promisc_set_vf(struct e1000_hw *hw, enum e10
 		break;
 	case e1000_promisc_enabled:
 		msgbuf |= E1000_VF_SET_PROMISC_MULTICAST;
+		/* FALLTHROUGH */
 	case e1000_promisc_unicast:
 		msgbuf |= E1000_VF_SET_PROMISC_UNICAST;
+		/* FALLTHROUGH */
 	case e1000_promisc_disabled:
 		break;
 	default:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805031547.w43Flg10048667>