Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Jan 2004 09:37:32 +0900 (JST)
From:      itojun@itojun.org (Jun-ichiro itojun Hagino)
To:        bzeeb-lists@lists.zabbadoz.net
Cc:        ume@freebsd.org
Subject:   Re: [PATCH] IPSec fixes
Message-ID:  <20040114003732.E0024A0@coconut.itojun.org>
In-Reply-To: Your message of "Tue, 13 Jan 2004 12:31:24 %2B0900 (JST)" <20040113033124.7F7BDA6@coconut.itojun.org>
References:  <20040113033124.7F7BDA6@coconut.itojun.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> > http://sources.zabbadoz.net/freebsd/patchset/110-ipsec-netkey-key.diff
> 	dunno if it is correct or not.  need more investigation.

	location of key_freesp() are wrong (you end up dereference freed
	pointer on ipseclog() because you call key_freesp() beforehand).
	other than that, those key_freesp() are needed.  thanks.

	as for key_sp_unlink(), i don't think the patch is correct.
	even if you do not call key_sp_unlink() in key_spdflush(), spd entries
	will get unlink'ed in key_timehandler().  therefore the end result
	will be the same.

itojun



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040114003732.E0024A0>