Date: Tue, 2 Jul 2013 19:00:46 -0400 From: Adam Weinberger <adamw@adamw.org> To: Felippe de Meirelles Motta <lippe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r321982 - in head/net: . hanstunnel hanstunnel/files Message-ID: <2F9D29C1-259B-41F0-9C67-00AAE5DBA69E@adamw.org> In-Reply-To: <CAJcxwRS73RvuYf1cYXMjzYktt44w_Bh=OvbZqtyELvYAxWC=1A@mail.gmail.com> References: <201306282045.r5SKjaZb090161@svn.freebsd.org> <20130701011908.GB9325@FreeBSD.org> <CAJcxwRS73RvuYf1cYXMjzYktt44w_Bh=OvbZqtyELvYAxWC=1A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2013-07-01, at 13:30, Felippe de Meirelles Motta <lippe@FreeBSD.org> = wrote: > danfe@, bsam@ and others thanks for the points mentioned, some I had = noticed, others I had really missed, but I just could not manipulate the = outcome of the patches without proper approval of the maintainer, = because this is your role. Sorry but I totally disagree. As committers, we (supposedly) know what = is best, and the right way to do things. External maintainers are = submitters; they can make mistakes and you can catch and fix them, = within reason. On the whole, people are quite appreciative when you = commit their patch quickly with small modifications, rather than = dragging the PR for weeks while you wait for a spelling fix. I mean, don't go changing the logic or anything, but all the time I = close PR's with "Committed, but I fixed MASTER_SITE to use the source = forge macro" or whatever. Never once have I heard anything except "Thank = you," and best of all, next time they submit a PR they get it right. I really don't understand why you'd rather commit something you know to = be wrong. DTRT and don't be a pedant. # Adam =20 -- Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2F9D29C1-259B-41F0-9C67-00AAE5DBA69E>