Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Oct 2014 18:32:20 -0400
From:      Ed Maste <emaste@freebsd.org>
To:        Rick Macklem <rmacklem@freebsd.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r273481 - head/sys/fs/nfsclient
Message-ID:  <CAPyFy2B19XkRQKAxpnTcfEjkG%2B=ZjYW2Z1%2BnR=yWQRfR9yytgQ@mail.gmail.com>
In-Reply-To: <201410222047.s9MKlBut062991@svn.freebsd.org>
References:  <201410222047.s9MKlBut062991@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 22 October 2014 16:47, Rick Macklem <rmacklem@freebsd.org> wrote:
> Author: rmacklem
> Date: Wed Oct 22 20:47:11 2014
> New Revision: 273481
> URL: https://svnweb.freebsd.org/changeset/base/273481
>
> Log:
>   Clip the settings for the NFS rsize, wsize mount options
>   to a power of 2.

For what it's worth, I fixed a similar issue in r248500 a while back.
It was an NFS bug and resulted in data corruption instead of a crash.
Anyhow, it appears these cases are not well tested so it does seem
reasonable to avoid them.

-Ed



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2B19XkRQKAxpnTcfEjkG%2B=ZjYW2Z1%2BnR=yWQRfR9yytgQ>