Date: Sat, 6 Jan 1996 12:28:10 -0800 (PST) From: Bill Paul <wpaul> To: CVS-committers, cvs-libexec Subject: cvs commit: src/libexec/ypxfr yp_dbwrite.c ypxfr_main.c Message-ID: <199601062028.MAA14299@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
wpaul 96/01/06 12:28:09
Modified: libexec/ypxfr yp_dbwrite.c ypxfr_main.c
Log:
Sync with my sources at home (these are really tiny changes):
- Fix a SEGV condition in ypxfr_main.c that reared its ugly head while I
was working on the 'parallel jobs' feature of the new yppush. After we've
completed the map transfer and created a local temporary copy, we check
the order number of the map on ypserv again to make sure it didn't change
while the transfer was in progress (map skew). If for some reason we flat
out fail to get the order number from the server, we flag this as an
error and bail, telling ypxfr_exit() to clean up our temporary files
for us. However, ypxfr_exit() tries to close the database before unkining
it, not realizing that it has already been closed prior to the skew check.
The second attempt to close the database causes a SEGV somewhere inside
the DB code.
(Well, it does on my 2.0.5 machine anyway. I haven't seen anyone modify
the DB library code in ages, so the condition is probably still there.)
To work around this, we deliberately set dbp to NULL after closing the
database and check for the condition in ypxfr_exit(), being careful to
avoid the second close if we see the NULL.
- In yp_dbwrite.c, make yp_open_db_rw() open the database with O_EXLOCK
flag set. This probably won't affect much of anything, but I feel better
having it there.
Revision Changes Path
1.2 +3 -3 src/libexec/ypxfr/yp_dbwrite.c
1.2 +12 -9 src/libexec/ypxfr/ypxfr_main.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199601062028.MAA14299>