Date: Tue, 19 Feb 2013 08:07:12 +0000 (UTC) From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org Subject: svn commit: r246982 - in stable: 7/contrib/wpa_supplicant 8/contrib/wpa/src/crypto 9/contrib/wpa/src/crypto Message-ID: <201302190807.r1J87Cd5018549@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dim Date: Tue Feb 19 08:07:11 2013 New Revision: 246982 URL: http://svnweb.freebsd.org/changeset/base/246982 Log: MFC r246875: Import change 40eebf235370b6fe6353784ccf01ab92eed062a5 from upstream wpa: From: Jouni Malinen <j@w1.fi> Date: Fri, 15 Jul 2011 13:42:06 +0300 Subject: [PATCH] MD5: Fix clearing of temporary stack memory to use correct length sizeof of the structure instead of the pointer was supposed to be used here. Fix this to clear the full structure at the end of MD5Final(). Found by: clang ToT Reviewed by: rpaulo Modified: stable/8/contrib/wpa/src/crypto/md5.c Directory Properties: stable/8/contrib/wpa/ (props changed) Changes in other areas also in this revision: Modified: stable/7/contrib/wpa_supplicant/md5.c stable/9/contrib/wpa/src/crypto/md5-internal.c Directory Properties: stable/7/contrib/wpa_supplicant/ (props changed) stable/9/contrib/wpa/ (props changed) Modified: stable/8/contrib/wpa/src/crypto/md5.c ============================================================================== --- stable/8/contrib/wpa/src/crypto/md5.c Tue Feb 19 07:55:53 2013 (r246981) +++ stable/8/contrib/wpa/src/crypto/md5.c Tue Feb 19 08:07:11 2013 (r246982) @@ -287,7 +287,7 @@ void MD5Final(unsigned char digest[16], MD5Transform(ctx->buf, (u32 *) ctx->in); byteReverse((unsigned char *) ctx->buf, 4); os_memcpy(digest, ctx->buf, 16); - os_memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */ + os_memset(ctx, 0, sizeof(*ctx)); /* In case it's sensitive */ } /* The four core functions - F1 is optimized somewhat */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302190807.r1J87Cd5018549>