Date: Thu, 22 Jan 2009 16:21:10 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Andrew Brampton <brampton+freebsd-fs@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: Pseudofs and pfs_attr_t for non-process based files Message-ID: <86iqo74ba1.fsf@ds4.des.no> In-Reply-To: <d41814900901210937y390cdff3pf6a9551df2c4bcd3@mail.gmail.com> (Andrew Brampton's message of "Wed, 21 Jan 2009 17:37:43 %2B0000") References: <d41814900901181701n7928e40cv2aa1dc4dff582fda@mail.gmail.com> <868wp4pqwm.fsf@ds4.des.no> <d41814900901210937y390cdff3pf6a9551df2c4bcd3@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrew Brampton <brampton+freebsd-fs@gmail.com> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > Sounds sensible, but your patches are mangled. Could you please > > regenerate them using 'svn diff -x-p' on a non-Windows machine? > When you say mangled, did you just mean they had windows new lines? That, and incorrect indentation, which your new patches fixed. A tip: if your MUA allows it, set the MIME-type for patches to text/x-patch (or, as last resort, text/plain), otherwise they may get stripped by mailing list software and some corporate / institutional email gateways. In procfs_attr(), the vap->va_[ug]id assignments are redundant, since at this point pfs_getattr() has already done the exact same thing. The rest of the patch is fine, modulo style issues which already existed in my code. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86iqo74ba1.fsf>