Date: Thu, 8 Dec 2005 14:20:13 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Doug Barton <dougb@freebsd.org> Cc: freebsd-rc@freebsd.org Subject: Re: For Review: Latest update to rcorder patch Message-ID: <20051208222013.GB5759@odin.ac.hmc.edu> In-Reply-To: <4398AB6A.3000209@FreeBSD.org> References: <4398AB6A.3000209@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--E39vaYmALEf/7YXx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 08, 2005 at 01:53:46PM -0800, Doug Barton wrote: > Howdy, >=20 > The attached patch contains what I hope are the final tweaks to the new= =20 > rcorder code. It has the following changes: >=20 > 1. Silences a grep warning when an rc.d directory in $local_startup is=20 > empty. >=20 > 2. Adds a variable to /etc/defaults/rc.conf called early_late_divider=20 > (better name suggestions welcome) that defines the script to use to=20 > separate the early and late stages, and the commensurate code in rc. This= =20 > makes the option configurable, which on the one hand puts a bullet in the= =20 > foot-shooting gun for careless admins, but on the other hand gives more= =20 > flexibility to those that can make use of it. >=20 > 3. Defaults the divider to mountcritlocal, instead of mountcritremote.=20 > When last I talked to Brooks about this, he said that this would=20 > "probably" be ok even for diskless booting, however I'm willing to make i= t=20 > mountcritremote for now if we're not sure of this. Alternatively, we can= =20 > make the default mountcritlocal, and instruct diskless booters to change= =20 > this setting. Since I am not really involved in the diskless booting=20 > stuff, I'm totally open to the consensus opinion on this. If we change it= ,=20 > this will move the following scripts into the late stage: Conceptually, I'm happy with this. A few things. - I'd suggest explicitly stating that the only sane values for $early_late_divider are probably root, mountcritlocal, and mountcritremote. - diskless.8 should probably be updated to mentation that early_late_divider must be set to mountcritremote for the documented configuration to work. - If you want to depend on an rc.conf value in /etc/rc, /etc/rc.d/rcconf.sh should die. early_late_divider is only non-zero every time through the loop by accident at this point. Since rcconf.sh is no longer needed due to moving rc.d/initdiskless back to /etc/rc.initdiskless, it's safe to handle configuration in /etc/rc. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --E39vaYmALEf/7YXx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDmLGcXY6L6fI4GtQRAn5XAJ4kQy0OYJwsc0rSC3aT9V3Sk/9Q9wCfXLop /B9ZaL5DRqdrOAGFeAXekTQ= =b0lj -----END PGP SIGNATURE----- --E39vaYmALEf/7YXx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051208222013.GB5759>