Date: Wed, 22 Oct 2003 11:54:49 -0400 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Andreas Klemm <andreas@freebsd.org> Cc: portmgr@freebsd.org Subject: Re: Approval for Hotfix needed for portscanner (was Re: Error assigning master socket: Too many open files) Message-ID: <1066837963.720.0.camel@gyros> In-Reply-To: <20031022153138.GA4102@titan.klemm.apsfilter.org> References: <20031022113039.GA10053@titan.klemm.apsfilter.org> <3F969491.5000405@openet-telecom.com> <20031022153138.GA4102@titan.klemm.apsfilter.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-+Wu2vlNoEBcq1T8F+N9k
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Wed, 2003-10-22 at 11:31, Andreas Klemm wrote:
> On Wed, Oct 22, 2003 at 03:30:41PM +0100, Peter Edwards wrote:
> > The patch applied by the port appears bogus. It adds braces around an=20
> > "if" that stops it executing the way it was intended. I've a sneaking=20
> > suspicion that the braces were added for "clarity", but the indentation=
=20
> > in the original file is so badly off that the terminating brace was put=
=20
> > in the wrong place. Try replacing patch-ab with this:
> >=20
> > --- portscanner.c.orig Wed Aug 19 18:37:44 1998
> > +++ portscanner.c Wed Oct 22 15:28:05 2003
> > @@ -25,8 +25,8 @@
> > /***********************************************************/
> >=20
> > #include <stdio.h>
> > -#include <sys/socket.h>
> > #include <sys/types.h>
> > +#include <sys/socket.h>
> > #include <netinet/in.h>
> > #include <unistd.h>
> > #include <netdb.h>
>=20
> Hi Peter,
>=20
> thanks a lot for your help. You're completely right with your
> diagnose and fix.
>=20
> I'll put portmgr@ on Cc: to be allowed to commit the change
> and will happily apply your fix to the port if I get the approval.
>=20
> look here:
>=20
> root@titan[ttyp2]{82} /usr/ports/security/portscanner portscanner -b 1 -e=
60000 -vv xx.xx.xx.xxx
> Resolving: xx.xx.xx.xxx -> resolved
> Current address: xx.xx.xx.xxx
> Port range: 1 to 60000
> Port 135 found. Service name: loc-srv
> Port 445 found. Service name: microsoft-ds
> Port 1025 found. Service name: blackjack
>=20
> Port scan finished !
>=20
> After changing the patch and reinstalling the port,
> the portscanner is completely functional again now.
Go for it.
Joe
>=20
> Best regards
>=20
> Andreas ///
--=20
PGP Key : http://www.marcuscom.com/pgp.asc
--=-+Wu2vlNoEBcq1T8F+N9k
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQA/lqfLb2iPiv4Uz4cRAgWxAKCmc+3olI7vxayeZUdvdDkSmWaRlwCfY39n
V6kPEvB+8wfOFt/oYY1mjiQ=
=5SHw
-----END PGP SIGNATURE-----
--=-+Wu2vlNoEBcq1T8F+N9k--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1066837963.720.0.camel>