Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Feb 1999 22:11:11 -0500 (EST)
From:      Chuck Robey <chuckr@mat.net>
To:        Garrett Wollman <wollman@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libmd Makefile sha.3
Message-ID:  <Pine.BSF.4.10.9902282205050.339-100000@picnic.mat.net>
In-Reply-To: <199903010239.SAA57887@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 28 Feb 1999, Garrett Wollman wrote:

> wollman     1999/02/28 18:39:45 PST
> 
>   Modified files:
>     lib/libmd            Makefile sha.3 
>   Log:
>   Don't even attempt to build the assembly-language versions of RIPEMD160
>   and SHA-1 when OBJFORMAT is not ELF.  Add a warning to the man page
>   about how SHA-1 uses bswapl, which will trap on 80386es (and the kernel
>   should, but doesn't currently, emulate).

I notice you mention the traps ... does that mean, during the time
window between when I committed John Polstra's suggestion about .align
(making both sha.S and rmd160.S compile for both elf and aout) and your
commit here completely disabling the building, someone could build a
kernel that would panic on a 386 processor?

If that's true, it would kinda require at least a pretty clear warning
here, which is why I'm asking.  I know it's a small time window, and
only for those running 386's, but fair is fair (if I caused this).

You did see my earlier commits to i386/sha.S and i386/rmd160.S, right?
When you didn't reply this morning, since the buildworld was broken (and
thus I didn't want to wait) I went ahead and stuck in what seemed like
the most minimal fix.

----------------------------+-----------------------------------------------
Chuck Robey                 | Interests include any kind of voice or data 
chuckr@glue.umd.edu         | communications topic, C programming, and Unix.
213 Lakeside Drive Apt T-1  |
Greenbelt, MD 20770         | I run picnic (FreeBSD-current)
(301) 220-2114              | and jaunt (Solaris7).
----------------------------+-----------------------------------------------






To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9902282205050.339-100000>