Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Jun 2016 17:24:12 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        "Jonathan T. Looney" <jtl@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r301814 - in head/sys: conf modules
Message-ID:  <3706c18e-cc5b-d20a-26eb-6914118f9071@FreeBSD.org>
In-Reply-To: <201606101906.u5AJ6BVE045417@repo.freebsd.org>
References:  <201606101906.u5AJ6BVE045417@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--hEixmUwjJRfNU60a5SIIjMg9uUIEcCPL0
Content-Type: multipart/mixed; boundary="mOJPLKDo8gAaSgeACukMUNeV3clcvCJPI"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: "Jonathan T. Looney" <jtl@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Message-ID: <3706c18e-cc5b-d20a-26eb-6914118f9071@FreeBSD.org>
Subject: Re: svn commit: r301814 - in head/sys: conf modules
References: <201606101906.u5AJ6BVE045417@repo.freebsd.org>
In-Reply-To: <201606101906.u5AJ6BVE045417@repo.freebsd.org>

--mOJPLKDo8gAaSgeACukMUNeV3clcvCJPI
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 6/10/2016 12:06 PM, Jonathan T. Looney wrote:
> Author: jtl
> Date: Fri Jun 10 19:06:11 2016
> New Revision: 301814
> URL: https://svnweb.freebsd.org/changeset/base/301814
>=20
> Log:
>   Change the default build behavior so we don't compile extra TCP modul=
es by
>   default. At least initially, the feature to support multiple TCP stac=
ks is
>   aimed at supporting advanced use cases and TCP development, but it is=
 not
>   necessarily aimed at a wide audience. Therefore, there is no need to =
build
>   and install the extra TCP stacks by default. Instead, the people who =
are
>   using or developing this functionality can add the extra option to bu=
ild/
>   install the extra TCP stacks.
>  =20
>   However, we do want to build the extra TCP stacks as part of test bui=
lds
>   (e.g. LINT or tinderbox) to ensure that developers who are testing th=
eir
>   changes will know that their changes do not break the additional TCP
>   stack modules.
>  =20
>   After this change, a user will need to add WITH_EXTRA_TCP_STACKS=3D1 =
to
>   make.conf or the kernel config in order to build the extra TCP module=
s.
>  =20
>   Differential Revision:	https://reviews.freebsd.org/D6795
>   Reviewed by:	sjg
>   Approved by:	re (kib)
>=20
> Modified:
>   head/sys/conf/kern.opts.mk
>   head/sys/conf/kern.post.mk
>   head/sys/modules/Makefile
>=20
> Modified: head/sys/conf/kern.opts.mk
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/conf/kern.opts.mk	Fri Jun 10 18:47:11 2016	(r301813)
> +++ head/sys/conf/kern.opts.mk	Fri Jun 10 19:06:11 2016	(r301814)
> @@ -45,6 +45,7 @@ __DEFAULT_YES_OPTIONS =3D \
> =20
>  __DEFAULT_NO_OPTIONS =3D \
>      EISA \
> +    EXTRA_TCP_STACKS \
>      NAND \
>      OFED

no description found for WITH_EXTRA_TCP_STACKS, skipping
A src.conf.5 handler is needed for this.


Please add a WITH_EXTRA_TCP_STACKS file into tools/build/options, svn
commit, svn up, and then
run from that directory:

=2E/makeman > ../../../share/man/man5/src.conf.5

Then commit ../../../share/man/man5/src.conf.5

(That's the process at least, both commits need re@ approval)

--=20
Regards,
Bryan Drewery


--mOJPLKDo8gAaSgeACukMUNeV3clcvCJPI--

--hEixmUwjJRfNU60a5SIIjMg9uUIEcCPL0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJXX06sAAoJEDXXcbtuRpfP2poH/3+2SCeoTQlWjd8xY1R+eSPU
MZt53w3hwwro7zeBfBZdPPM2S5zMyfHKc8ogpKDbu2WNbn69eYPQ3D9XkxKoZyRN
bzs4XO99f2BwPPDE6KK0rygWgPXKkaVoZa6sXvbMPinKKcp1ctC2cl423cGDZYD9
c2Wx3raGxj6Xi+Iz/2Y7aGN+ogmAdKW1r8VtAOs95/2v8x7eZPa0k15gdCqWVIj3
hLoFCvXOrsDITRekpdmH0kj9jBPX7VBOPM8EK87dglkbsI+hMkR69ycK25T7iS61
abof8JtK9Y53k7OkPqfl6Y58pjgbUiOfzXWYK/vj2YzrKNU2fn98wyl+wKtbap0=
=ASSR
-----END PGP SIGNATURE-----

--hEixmUwjJRfNU60a5SIIjMg9uUIEcCPL0--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3706c18e-cc5b-d20a-26eb-6914118f9071>