Date: Sun, 16 May 2021 00:36:34 +0200 From: Lutz Donnerhacke <lutz@donnerhacke.de> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Lutz Donnerhacke <donner@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: effc8e57fbf0 - main - libalias: Style cleanup Message-ID: <20210515223634.GA21814@belenus.iks-jena.de> In-Reply-To: <YKA9jrWPkeCUgwPf@kib.kiev.ua> References: <202105150701.14F717lf084359@gitrepo.freebsd.org> <YKAkAcYHXN7XMyoL@kib.kiev.ua> <20210515195812.GB17734@belenus.iks-jena.de> <YKArpyRTTAah4LSG@kib.kiev.ua> <20210515205133.GA19770@belenus.iks-jena.de> <YKA9jrWPkeCUgwPf@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 16, 2021 at 12:30:54AM +0300, Konstantin Belousov wrote: > > The LIBALIAS_LOCK_ASSERT and the variable declarations were not moved. > So you changed some style, but left the large violation in place. This cleanup is a preparation to fix various issues in this code. So yes, the change was intentionally limited to style issues. Mixing style and functional changes makes it very hard to track down a broken behavior to a single commit. This change is huge, it must not break anything.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210515223634.GA21814>