Date: Thu, 15 May 2014 16:19:36 +0200 From: Oliver Pinter <oliver.pntr@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: arch@freebsd.org, gavin@freebsd.org, current@freebsd.org Subject: Re: [RFC] remove dead code from link_elf.c Message-ID: <CAPjTQNGRq-Jb4HxjgagqeA-eBHtJMh9g6Q-jk=0CSz-jU57w0Q@mail.gmail.com> In-Reply-To: <20140515135003.GO74331@kib.kiev.ua> References: <CAPjTQNHTiEeSuf9y4Ddriq5Jj7L6yYNSqLujH2ni=XdUF5b-bg@mail.gmail.com> <20140515135003.GO74331@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/15/14, Konstantin Belousov <kostikbel@gmail.com> wrote: > On Thu, May 15, 2014 at 03:36:51PM +0200, Oliver Pinter wrote: >> Hi all! >> >> I found that the SPARSE_MAPPING used only in sys/kern/link_elf.c file, >> and no other place in kernel, nor in generated codes in /usr/obj/... >> >> op@pandora-d opBSD.git> git grep -i SPARSE_MAPPING >> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING >> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING >> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING >> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING >> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING >> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING >> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING >> >> I proposed to remove the old/dead codes. Patch attached. Tested on amd64. > > I agree that SPARSE_MAPPING could go away. But your testing is void, > since link_elf.c is practically not used on amd64, which utilizes object > file format for klds. > Hi kib@ Thanks for the quick response.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPjTQNGRq-Jb4HxjgagqeA-eBHtJMh9g6Q-jk=0CSz-jU57w0Q>