Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Feb 2016 23:00:01 +0000 (UTC)
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r295775 - head/sys/contrib/x86emu
Message-ID:  <201602182300.u1IN01KW042324@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jkim
Date: Thu Feb 18 23:00:01 2016
New Revision: 295775
URL: https://svnweb.freebsd.org/changeset/base/295775

Log:
  Silence VPS-Studio errors (V646).  These is no functional change.

Modified:
  head/sys/contrib/x86emu/x86emu.c

Modified: head/sys/contrib/x86emu/x86emu.c
==============================================================================
--- head/sys/contrib/x86emu/x86emu.c	Thu Feb 18 22:40:24 2016	(r295774)
+++ head/sys/contrib/x86emu/x86emu.c	Thu Feb 18 23:00:01 2016	(r295775)
@@ -7003,7 +7003,7 @@ rol_byte(struct x86emu *emu, uint8_t d, 
 		CONDITIONAL_SET_FLAG(s == 1 &&
 		    XOR2((res & 0x1) + ((res >> 6) & 0x2)),
 		    F_OF);
-	} if (s != 0) {
+	} else if (s != 0) {
 		/* set the new carry flag, Note that it is the low order bit
 		 * of the result!!!                               */
 		CONDITIONAL_SET_FLAG(res & 0x1, F_CF);
@@ -7029,7 +7029,7 @@ rol_word(struct x86emu *emu, uint16_t d,
 		CONDITIONAL_SET_FLAG(s == 1 &&
 		    XOR2((res & 0x1) + ((res >> 14) & 0x2)),
 		    F_OF);
-	} if (s != 0) {
+	} else if (s != 0) {
 		/* set the new carry flag, Note that it is the low order bit
 		 * of the result!!!                               */
 		CONDITIONAL_SET_FLAG(res & 0x1, F_CF);
@@ -7055,7 +7055,7 @@ rol_long(struct x86emu *emu, uint32_t d,
 		CONDITIONAL_SET_FLAG(s == 1 &&
 		    XOR2((res & 0x1) + ((res >> 30) & 0x2)),
 		    F_OF);
-	} if (s != 0) {
+	} else if (s != 0) {
 		/* set the new carry flag, Note that it is the low order bit
 		 * of the result!!!                               */
 		CONDITIONAL_SET_FLAG(res & 0x1, F_CF);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201602182300.u1IN01KW042324>