Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 Jan 2017 14:32:13 -0800
From:      Ngie Cooper <yaneurabeya@gmail.com>
To:        Dimitry Andric <dim@freebsd.org>
Cc:        Ian Lepore <ian@freebsd.org>,  "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r311929 - head/sys/boot/common
Message-ID:  <CAGHfRMBGY=SUHLoUB8qLv2pFXNkFDoDdHW2Xqu97xgba6pY0Yg@mail.gmail.com>
In-Reply-To: <8EF36240-8CD0-449E-AA9C-EFFB7BF0C111@FreeBSD.org>
References:  <201701111847.v0BIl0Mg013954@repo.freebsd.org> <CAGHfRMBy7KPP=vLjEpyfRuf_u4S%2B2mO_W3US9WodMf=ckRJKBQ@mail.gmail.com> <1484170956.86335.17.camel@freebsd.org> <8EF36240-8CD0-449E-AA9C-EFFB7BF0C111@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 11, 2017 at 2:10 PM, Dimitry Andric <dim@freebsd.org> wrote:

...

> The line:
>
>     extern int errno;
>
> expanded to:
>
>     extern int (* __error());
>
> which is a declaration of an external function pointer called __error
> (albeit with an empty parameter list).  Since nobody actually refers to
> this symbol in libstand, there are no later complaints.
>
> Interestingly, reloc_elf.c does not use errno at all, so I have no idea
> why the include was originally added.

This is why:

95dd728f5ca86 (iedowse  2004-08-28 23:03:05 +0000 221) #else
95dd728f5ca86 (iedowse  2004-08-28 23:03:05 +0000 222)  return (EOPNOTSUPP);
95dd728f5ca86 (iedowse  2004-08-28 23:03:05 +0000 223) #endif

You probably just broke tinderbox on non-x86/-powerpc.
Cheers,
-Ngie



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMBGY=SUHLoUB8qLv2pFXNkFDoDdHW2Xqu97xgba6pY0Yg>