Date: Thu, 23 May 2013 13:00:41 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Martin Wilke <miwi.freebsd@gmail.com>, Chris Rees <crees@freebsd.org>, Ports Management Team <portmgr@freebsd.org>, FreeBSD Ports <ports@freebsd.org>, Eitan Adler <lists@eitanadler.com>, Olivier Smedts <olivier@gid0.org>, Martin Wilke <miwi@bsdhash.org>, Bryan Drewery <bryan@shatow.net> Subject: Re: Plans for making MAKE_JOBS_SAFE the default? Message-ID: <20130523130041.GA47068@FreeBSD.org> In-Reply-To: <519E0912.4070500@FreeBSD.org> References: <CAF6rxgkjxAmFjr=qp%2BDC83AqvY4CMXVn5=CQCfQi_aKn3bnoRQ@mail.gmail.com> <50463F7F.2030502@shatow.net> <CABzXLYNQBVZAkL%2B-HMUVduzq_UKLEjbQFE4zn_KhCBE3agX-Hw@mail.gmail.com> <CAF6rxgmx0bJcW-iP_a8B3y9x9T%2BxF0MNsW55ciJJOnKPfQEMSA@mail.gmail.com> <CADLo83-126TsyWatUREysrk2gR7%2BacxWqTxmW0WhwH=QYW=hfg@mail.gmail.com> <CAF6rxgk-kL6UXRES6KWqQtOSd6rvKV4E-hgHLcAXSCEA9vVy-g@mail.gmail.com> <1A22DCEC-9548-4FD2-BFC5-4F3F4EC1E1C2@gmail.com> <A8B05539-6878-48DE-8DC0-3323263594AF@bsdhash.org> <20130523075627.GA79696@FreeBSD.org> <519E0912.4070500@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 23, 2013 at 07:18:26AM -0500, Bryan Drewery wrote: > On 5/23/2013 2:56 AM, Alexey Dokuchaev wrote: > > FORCE_MAKE_JOBS is removed because it is the default. While here, I've > > moved empty(MAKE_JOBS_NUMBER) check higher, IMHO where it should belong, > > also saves a few lines. Reviews are welcome. > > Moving MAKE_JOBS_NUMBER is wrong, see r317639 Hmm, can you explain a bit more? Maybe I am missing something here, but as I read log for r317639: "[F]ix MAKE_JOBS_NUMBER not being set if none of DISABLE_MAKE_JOBS or MAKE_JOBS_UNSAFE or MAKE_JOBS_SAFE or FORCE_MAKE_JOBS were set." Previously (without my patch) it could happen because of nested .if's. Now _MAKE_JOBS is set in both branches (true and false). Simple test on a port that does not set any MAKE_JOBS_* stuff, e.g. games/qcc: $ make -V MAKE_JOBS_NUMBER `/sbin/sysctl -n kern.smp.cpus` $ make -V MAKE_JOBS_NUMBER -DDISABLE_MAKE_JOBS 1 $ make -V MAKE_JOBS_NUMBER -DMAKE_JOBS_UNSAFE 1 $ make -V MAKE_JOBS_NUMBER -DMAKE_JOBS_SAFE `/sbin/sysctl -n kern.smp.cpus` $ make -V MAKE_JOBS_NUMBER -DFORCE_MAKE_JOBS `/sbin/sysctl -n kern.smp.cpus` Can you show how can I get undefined _MAKE_JOBS? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130523130041.GA47068>