Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Jul 2020 19:16:07 +0200
From:      Michael Gmelin <freebsd@grem.de>
To:        Fabian Abplanalp - Legatech GmbH <fabian@legatech.ch>
Cc:        "ports@freebsd.org" <ports@freebsd.org>
Subject:   Re: FreeBSD Port: phabricator-php73-20200514_1
Message-ID:  <20200721191607.06148356@bsd64.grem.de>
In-Reply-To: <43F0A9E9-0930-424F-A98C-741F18517AE6@grem.de>
References:  <d0ce54d6-89ca-b917-32ef-134c07b1ae18@legatech.ch> <43F0A9E9-0930-424F-A98C-741F18517AE6@grem.de>

next in thread | previous in thread | raw e-mail | index | archive | help


On Tue, 16 Jun 2020 10:39:30 +0200
Michael Gmelin <freebsd@grem.de> wrote:

> > On 16. Jun 2020, at 08:41, Fabian Abplanalp - Legatech GmbH
> > <fabian@legatech.ch> wrote:
> >=20
> > =EF=BB=BFHi
> >=20
> > Since we updated the Port to 20200514_1 we can't create milestones
> > anymore with the following information... Is there anything known
> > about that problem or should we place a bugreport at phabricator?
> >=20
> > Reproducible case (on our phab-test):
> >=20
> > Get PHID of the project where I want to add a milestone:
> > https://phab-test.neratec.com/conduit/method/phid.lookup/
> > names: ["#software_team"]
> > result:
> > { "#software_team":
> >   { "phid": "PHID-PROJ-32jtopr6klyrrpxe3pow",
> >     "uri": "https://phab-test.neratec.com/tag/software_team/",
> >     "typeName": "Project",
> >     "type": "PROJ",
> >     "name": "Software Team",
> >     "fullName": "Software Team",
> >     "status": "open"
> >   }
> > }
> > Try to create milestone of "Software Team" project
> > https://phab-test.neratec.com/conduit/method/project.edit/
> > transactions:
> > [{"type":"milestone","value":"PHID-PROJ-32jtopr6klyrrpxe3pow"},{"type":=
"name","value":"2020.15"},{"type":"description","value":"=3D
> > Sprint 2020.15"}] Conduit > Unhandled Exception ("Error") Call to a
> > member function getPHID() on null Error on server shows: EXCEPTION:
> > (Error) Call to a member function getPHID() on null at
> > [<phabricator>/src/applications/project/editor/PhabricatorProjectTransa=
ctionEditor.php:358]=20
>=20
> Based on staring at the code[0], my wild guess is that your conduit
> user has no or insufficient access to the parent project (above the
> code referenced a copy of parent is created and adjusted for
> permissions).
>=20
> The ticket referenced in the code can be found here[1].
>=20
> Best,
> Michael
>=20
> [0]
> https://github.com/phacility/phabricator/blob/d203a1004c7509109fccdf526e9=
941b89eeef662/src/applications/project/editor/PhabricatorProjectTransaction=
Editor.php#L349
>=20
> [1] https://secure.phabricator.com/T13462
>=20

Hi Fabian,

I could reproduce the problem locally and found a fix:
https://github.com/grembo/phabricator/commit/0851b89eb6633dd792cd4eb10c26f8=
6c2f0da56a

I also reported it upstream (where there was already a six month old,
unsolved report of that specific problem):
https://discourse.phabricator-community.org/t/call-to-a-member-function-get=
phid-on-a-non-object-while-creating-milestone-using-conduit/3370/4

I already incorporated it as a patch into the port, so
phabricator-php73-20200514_2 will solve this problem for you.

The new version is committed and should be available over portsnap
for source builds shortly and as a binary package to be used with pkg
within the next couple of days.

Cheers,
Michael

--=20
Michael Gmelin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200721191607.06148356>