Date: Mon, 8 Feb 2010 20:14:34 GMT From: "Joseph S. Atkinson" <jsa@wickedmachine.net> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/143678: Remove update checks from ftp/filezilla Message-ID: <201002082014.o18KEYq6039750@www.freebsd.org> Resent-Message-ID: <201002082020.o18KK4BW065201@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 143678
>Category: misc
>Synopsis: Remove update checks from ftp/filezilla
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Feb 08 20:20:04 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Joseph S. Atkinson
>Release:
>Organization:
>Environment:
>Description:
By default, FileZilla has automatic update checks enabled. For FreeBSD, this is a bit pointless since SF doesn't build packages for us. This might just cause some false alarm that the software is unmaintained in the interim between release, port update, and packages being pushed to the FTP servers.
At the very least, it's mostly irrelevant pop up spam for FreeBSD users that will show at every application launch if their version is not the most current.
This bump disables this behavior unless MAINTAINER_MODE is defined.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
diff -ru /usr/ports/ftp/filezilla/Makefile filezilla/Makefile
--- /usr/ports/ftp/filezilla/Makefile 2010-02-06 15:32:36.000000000 -0500
+++ filezilla/Makefile 2010-02-08 14:57:05.000000000 -0500
@@ -7,7 +7,7 @@
PORTNAME= filezilla
PORTVERSION= 3.3.1
-PORTREVISION= 1
+PORTREVISION= 2
CATEGORIES= ftp
MASTER_SITES= SF/${PORTNAME}/FileZilla_Client/${PORTVERSION}
DISTNAME= FileZilla_${PORTVERSION}_src
@@ -51,6 +51,10 @@
PLIST_SUB+= NLS="@comment "
.endif
+.if !defined(MAINTAINER_MODE)
+CONFIGURE_ARGS+= --disable-manualupdatecheck
+.endif
+
post-patch:
@${REINPLACE_CMD} -Ee 's|(dummy) wxrc|\1 ${WXRC_CMD:T}|' \
${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201002082014.o18KEYq6039750>