Date: Wed, 16 Jan 2019 08:33:22 -0700 From: Ian Lepore <ian@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Justin Hibbits <chmeeedalf@gmail.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm Message-ID: <604708565c923c1fdba0924ccc497ee5cb6595d8.camel@freebsd.org> In-Reply-To: <20190115203316.GA18452@FreeBSD.org> References: <201901151933.x0FJXl8a069317@repo.freebsd.org> <20190115134623.139064b2@titan.knownspace> <20190115200617.GZ18452@FreeBSD.org> <79ee763bb72a47f3e7888caf266174a62c23e532.camel@freebsd.org> <20190115203316.GA18452@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2019-01-15 at 12:33 -0800, Gleb Smirnoff wrote: > On Tue, Jan 15, 2019 at 01:20:14PM -0700, Ian Lepore wrote: > I> On Tue, 2019-01-15 at 12:06 -0800, Gleb Smirnoff wrote: > I> > On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote: > I> > J> Why not #include counter.h in the relevant vm_machdep.c files > I> > instead? > I> > > I> > This also is ugly :( Not sure more or less. Probably less, but I > I> > urged to plug all possible compilation failures at a time. > I> > > I> > What is ugly is that most files just need counter_u64_t size, > I> > and they don't use counter(9) KPI. > I> > > I> > The fact that vm_machdep or Linux KPI want to look into internal > I> > type uma_zone_t is also ugly. > I> > > I> > I> Isn't the usual fix for this problem to create a __counter_u64_t > in > I> sys/types.h and use it in places where including the full header > file > I> is undesirable for some reason? > > I'm inclined to this solution. Do you want to sign up as reviewer? :) > I can barely keep up with reading all my freebsd-related email these days, I'd better not commit to a review that I may not actually get around to. :/ -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?604708565c923c1fdba0924ccc497ee5cb6595d8.camel>