Date: Thu, 13 Feb 2003 02:10:09 +0100 (CET) From: Matthias Andree <matthias.andree@web.de> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/48221: portlint: bogus warnings about DISTFILES Message-ID: <200302130110.h1D1A9w3006124@libertas.emma.line.org>
next in thread | raw e-mail | index | archive | help
>Number: 48221
>Category: ports
>Synopsis: portlint: bogus warnings about DISTFILES
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Feb 12 17:20:07 PST 2003
>Closed-Date:
>Last-Modified:
>Originator: Matthias Andree
>Release: FreeBSD 4.7-STABLE i386
>Organization:
>Environment:
System: FreeBSD libertas.emma.line.org 4.7-STABLE FreeBSD 4.7-STABLE #8: Fri Jan 31 03:10:11 CET 2003 toor@libertas.emma.line.org:/usr/obj/usr/src/sys/LIBERTAS i386
>Description:
portlint is too picky about some constructs:
The new feature of adding :CLASS style grouping to master sites and subdirs
requires the use of DISTFILES with a single file -- portlint complains:
WARN: use of DISTFILES with single file discouraged. distribution filename
should be set by DISTNAME and EXTRACT_SUFX.
Also, this warning is utterly bogus and will catch a lot of ports that use
automake or similar "make dist" schemes but have a name that is inadequate
for FreeBSD's port system:
WARN: do not use DISTFILES and DISTNAME to control WRKSRC. how about "WRKSRC=${WRKDIR}/${PORTNAME}-${PORTVERSION}.rel"?
WKRSRC is implicitly derived using DISTNAME in /usr/ports/Mk/bsd.port.mk, so
this warning is bogus -- or /usr/ports/Mk/bsd.port.mk should be fixed instead.
>How-To-Repeat:
Check out ports/news/leafnode with -D '2003-02-13 01:00' (that's GMT), it
should yield Makefile 1.28 or 1.29 (both reproduce the problem). Then
run portlint in that port's directory.
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200302130110.h1D1A9w3006124>