Date: Thu, 11 Nov 2010 00:20:55 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Bruce Evans <brde@optusnet.com.au> Cc: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net>, freebsd-bugs@FreeBSD.org Subject: Re: bin/144306: [libm] [patch] Nasty bug in jn(3) Message-ID: <20101111001705.Q1801@besplex.bde.org> In-Reply-To: <20101110225059.M1461@besplex.bde.org> References: <201011092010.oA9KABNt076837@freefall.freebsd.org> <20101110225059.M1461@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 10 Nov 2010, Bruce Evans wrote: > [...unrelated] Just noticed a minor bug in the float version: from the PR: % diff --git a/lib/msun/src/e_jnf.c b/lib/msun/src/e_jnf.c % index 3bbf7b7..d045bb05 100644 % --- a/lib/msun/src/e_jnf.c % +++ b/lib/msun/src/e_jnf.c % @@ -152,7 +152,12 @@ __ieee754_jnf(int n, float x) % } % } % } % - b = (t*__ieee754_j0f(x)/b); % + z = __ieee754_j0f(x); % + w = __ieee754_j1f(x); % + if (fabs(z) >= fabs(w)) This should use fabsf(). % + b = (t*z/b); % + else % + b = (t*w/a); % } % } % if(sgn==1) return -b; else return b; % Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101111001705.Q1801>