Date: Mon, 28 Nov 2005 11:32:11 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-hackers@freebsd.org Cc: Antony Mawer <fbsd-hackers@mawer.org> Subject: Re: libutil properties_read() bug: patch for review Message-ID: <200511281132.12192.jhb@freebsd.org> In-Reply-To: <438505D6.7090202@mawer.org> References: <438505D6.7090202@mawer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 23 November 2005 07:14 pm, Antony Mawer wrote: > Hi, > > I recently hit upon a bug in sysinstall, getting an "Invalid realloc > size of 0" error that caused sysinstall to terminate. I eventually > tracked it down to a bug in the properties_read() function of libutil, > which occurs only when reading a properties file of 4096 bytes or > greater. This is because libutil discards its current state when the > buffer runs out (4096 bytes) and it must refill the buffer, causing the > properties file (*.inf) to be incorrectly read. > > I've made a patch that's attached to the PR I filed, PR 89181, but was > hoping to get some extra eyes on the patch to make sure that there's > nothing amiss with the patch: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=89181 > > Hopefully someone can review this and see about getting it committed for > 6.1! I just committed it to HEAD. It should be MFC'd in time for both 5.5 and 6.1. Thanks! -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511281132.12192.jhb>