Date: Tue, 29 Jun 2010 17:42:33 GMT From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/148239: [PATCH] unbreak graphics/libchamplain python bindings. Feature-safe: yes Message-ID: <201006291742.o5THgXWD076892@www.freebsd.org> Resent-Message-ID: <201006291750.o5THo6LL005546@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 148239 >Category: ports >Synopsis: [PATCH] unbreak graphics/libchamplain python bindings. Feature-safe: yes >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jun 29 17:50:05 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Ruslan Mahmatkhanov >Release: 8.1-PRERELEASE >Organization: >Environment: 8.1-PRERELEASE i386 >Description: Version 0.4.6 of libchamplain (that now in ports tree) contains bug, that breaks python bindings (champlain.so). You can read this for details: https://bugzilla.gnome.org/show_bug.cgi?id=622232 The problem is that libchamplain tarball contains bull-sized bindings/python/champlain/pychamplain.c (that is autogenerated) and so this breaks the things (while builds and installs correctly). As author said 0.4.7 that will contain the fix will not be released right now, so there is the patch that removes pychamplain.c on post-patch files to let the Makefile generate it from scratch. It's completely feature safe and actually i vote for commit this before port freeze, as this breaks all the apps in ports that rely upon champlain.so (deskutils/gtg for example). >How-To-Repeat: Install graphics/libchamplain. run python -c "import champlain". You'll get this: Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: /usr/local/lib/python2.6/site-packages/champlain.so: Undefined symbol "champlain_functions" >Fix: Patch attached with submission follows: diff -ruNa libchamplain/Makefile libchamplain/Makefile --- libchamplain/Makefile 2010-06-29 21:27:50.000000000 +0400 +++ libchamplain/Makefile 2010-06-29 21:29:14.000000000 +0400 @@ -8,6 +8,7 @@ PORTNAME= libchamplain PORTVERSION= 0.4.6 +PORTREVISION= 1 CATEGORIES= graphics MASTER_SITES= GNOME @@ -52,5 +53,8 @@ post-patch: @${REINPLACE_CMD} -e 's|pyclutter-gtk-0.9|pyclutter-gtk-0.10|g' \ ${WRKSRC}/configure + # This is a trick for make python bindings work again + # Can be safely removed after 0.4.7 release + @${RM} -f ${WRKSRC}/bindings/python/champlain/pychamplain.c .include <bsd.port.mk> >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006291742.o5THgXWD076892>