Date: Mon, 22 Apr 2019 21:18:11 +0800 (WITA) From: Gerald Pfeifer <gerald@pfeifer.com> To: =?UTF-8?Q?T=C4=B3l_Coosemans?= <tijl@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r499061 - in head/lang/gcc8: . files Message-ID: <alpine.LSU.2.21.1904222116380.5123@anthias.pfeifer.com> In-Reply-To: <20190416124613.4aeaacc1@kalimero.tijl.coosemans.org> References: <201904152308.x3FN84eO052473@repo.freebsd.org> <20190416124613.4aeaacc1@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 16 Apr 2019, Tijl Coosemans wrote: >> PR: 208120 >> Submitted by: tijl >> MFH: 2019Q2 (important user visible improvement) >> >> Added: >> head/lang/gcc8/files/patch-gfortran-libgcc (contents, props changed) >> Modified: >> head/lang/gcc8/Makefile > Thank you very much! Ports with USES=fortran could probably use a > PORTREVISION bump so they can take advantage of the change. I was wondering about that and did not do it as part of the original commit, but yours is a good follow up suggestion, so I now (finally -- sorry, being in training the last ten days) added that as well. Thank you! Gerald From owner-svn-ports-all@freebsd.org Mon Apr 22 13:31:34 2019 Return-Path: <owner-svn-ports-all@freebsd.org> Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9116159A254; Mon, 22 Apr 2019 13:31:34 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 600748AB5F; Mon, 22 Apr 2019 13:31:34 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3BD60D923; Mon, 22 Apr 2019 13:31:34 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x3MDVYbH011837; Mon, 22 Apr 2019 13:31:34 GMT (envelope-from tobik@FreeBSD.org) Received: (from tobik@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x3MDVY54011836; Mon, 22 Apr 2019 13:31:34 GMT (envelope-from tobik@FreeBSD.org) Message-Id: <201904221331.x3MDVY54011836@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: tobik set sender to tobik@FreeBSD.org using -f From: Tobias Kortkamp <tobik@FreeBSD.org> Date: Mon, 22 Apr 2019 13:31:34 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r499639 - head/net-mgmt/dhcdrop X-SVN-Group: ports-head X-SVN-Commit-Author: tobik X-SVN-Commit-Paths: head/net-mgmt/dhcdrop X-SVN-Commit-Revision: 499639 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 600748AB5F X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.94 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.936,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>, <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>; List-Post: <mailto:svn-ports-all@freebsd.org> List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>, <mailto:svn-ports-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Mon, 22 Apr 2019 13:31:35 -0000 Author: tobik Date: Mon Apr 22 13:31:33 2019 New Revision: 499639 URL: https://svnweb.freebsd.org/changeset/ports/499639 Log: net-mgmt/dhcdrop: Fix build on FreeBSD >= 12.0 and unbreak STATIC option Add missing libibverbs dependency when linking statically. On FreeBSD >= 12.0 libpcap needs libibverbs: /usr/bin/ld: error: undefined symbol: ibv_get_device_list >>> referenced by pcap-rdmasniff.c:370 (/usr/src/contrib/libpcap/pcap-rdmasniff.c:370) >>> pcap-rdmasniff.o:(rdmasniff_create) in archive /usr/lib/libpcap.a http://beefy6.nyi.freebsd.org/data/120amd64-default/499421/logs/errors/dhcdrop-0.5_2.log While here fix the STATIC option. Currently the port always links statically since --disable-static-build is broken and also enables static linking. Reported by: antoine, pkg-fallout Modified: head/net-mgmt/dhcdrop/Makefile Modified: head/net-mgmt/dhcdrop/Makefile ============================================================================== --- head/net-mgmt/dhcdrop/Makefile Mon Apr 22 13:16:33 2019 (r499638) +++ head/net-mgmt/dhcdrop/Makefile Mon Apr 22 13:31:33 2019 (r499639) @@ -3,7 +3,7 @@ PORTNAME= dhcdrop PORTVERSION= 0.5 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= net-mgmt sysutils MASTER_SITES= http://www.netpatch.ru/projects/dhcdrop/ @@ -22,6 +22,16 @@ PLIST_FILES= sbin/dhcdrop man/man8/dhcdrop.8.gz \ OPTIONS_DEFINE= STATIC STATIC_DESC= Build a static version of dhcdrop -STATIC_CONFIGURE_ENABLE= static-build +# --disable-static-build is broken and has the same effect as +# --enable-static-build, so do not use STATIC_CONFIGURE_ENABLE +# here. +STATIC_CONFIGURE_ON= --enable-static-build + +.if exists(/usr/lib/libibverbs.a) +# Link with libibverbs too needed by static libpcap +post-patch-STATIC-on: + @${REINPLACE_CMD} -e 's,^dhcdrop_LDADD.*,& -libverbs,' \ + ${WRKSRC}/src/Makefile.am +.endif .include <bsd.port.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1904222116380.5123>