Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Jun 2002 17:38:07 +0200
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        Mike Barcroft <mike@FreeBSD.ORG>
Cc:        Robert Drehmel <robert@zoot.drehmel.com>, current@FreeBSD.ORG, robert@FreeBSD.ORG
Subject:   Re: changing 'struct utmp' 
Message-ID:  <4381.1025278687@critter.freebsd.dk>
In-Reply-To: Your message of "Fri, 28 Jun 2002 11:34:54 EDT." <20020628113454.B34516@espresso.q9media.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020628113454.B34516@espresso.q9media.com>, Mike Barcroft writes:
>Robert Drehmel <robert@zoot.drehmel.com> writes:
>> While trying to fix the bug described in a problem report about
>> 'w -n', and finding out that it is somewhat broken*, I came to
>> the conclusion that our 'struct utmp' is too limiting.
>> 
>> I would like to modernize it as follows:
>> 
>> #define	UT_USERSIZE		16
>> #define	UT_LINESIZE		8
>> #define	UT_HOSTSIZE		18	/* increase by two bytes */
>
>I think it might be a wise idea to make UT_HOSTSIZE much larger.
>Currently, it isn't even large enough to hold an IPv6 address.

really guys, we need to do this right.

The entire "line-number from /etc/ttys is index into file" concept
sucks.

Fixed sized records suck badly.

Please, if you're going to do it, do it right.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4381.1025278687>