Date: Tue, 14 Sep 2010 08:20:06 GMT From: Martin Matuska <mm@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/150544: Panic, when viewing the list of ZFS snapshots Message-ID: <201009140820.o8E8K6Cx056610@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/150544; it has been noted by GNATS. From: Martin Matuska <mm@FreeBSD.org> To: jhell <jhell@DataIX.net> Cc: Pawel Jakub Dawidek <pjd@FreeBSD.org>, Andriy Gapon <avg@FreeBSD.org>, "Vladislav V. Prodan" <universite@ukr.net>, bug-followup@FreeBSD.org Subject: Re: kern/150544: Panic, when viewing the list of ZFS snapshots Date: Tue, 14 Sep 2010 10:15:02 +0200 This is a multi-part message in MIME format. --------------050904040905030901040700 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There was one important line missing from the merge from pjd's p4 branch. Please confirm if this patch works and I will commit it ASAP. Dňa 14. 9. 2010 10:06, jhell wrote / napísal(a): > On 09/14/2010 03:45, Pawel Jakub Dawidek wrote: >> On Tue, Sep 14, 2010 at 10:25:36AM +0300, Andriy Gapon wrote: >>> on 14/09/2010 09:35 Andriy Gapon said the following: >>>> >>>> Maybe this happens because we don't really support .zfs/shares, but create (or >>>> try to create) that directory for some reason? >>>> >>> >>> Could you please test this patch? > >> The problem was introduced AFAIK by Martin's import of v15. I think it >> is handled in my v28 properly, but would need to double check. All in >> all, I'd prefer if Martin could handle the problem, as I wasn't involved >> in v15 and it is hard to say for me in what shape it is and what bits >> are missing (Martin CCed). > >>> --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c >>> +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c >>> @@ -128,7 +128,6 @@ static int zfsctl_unmount_snap >>> */ >>> static gfs_dirent_t zfsctl_root_entries[] = { >>> { "snapshot", zfsctl_mknode_snapdir, GFS_CACHE_VNODE }, >>> - { "shares", zfsctl_mknode_shares, GFS_CACHE_VNODE }, >>> { NULL } >>> }; > > > Andriy, > That patch-up did solve it. As for what those shares directories are > good for I am not sure. Do they effect the sharenfs properties at all ?. > If so then I know to not apply this and to just not ls(1) or cd(1) that > directory until a more proper fix has been applied. > > > Pawel, > Alright future replies if I am reading into it correctly, you will be > removed from CC. Thank you for listening && looking in. > > > Regards & Thanks again, > --------------050904040905030901040700 Content-Type: text/plain; name="zfs_ctldir.c.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="zfs_ctldir.c.patch" SW5kZXg6IHN5cy9jZGRsL2NvbnRyaWIvb3BlbnNvbGFyaXMvdXRzL2NvbW1vbi9mcy96ZnMv emZzX2N0bGRpci5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9jZGRsL2NvbnRyaWIvb3BlbnNv bGFyaXMvdXRzL2NvbW1vbi9mcy96ZnMvemZzX2N0bGRpci5jCShyZXZpc2lvbiAyMTI0OTEp CisrKyBzeXMvY2RkbC9jb250cmliL29wZW5zb2xhcmlzL3V0cy9jb21tb24vZnMvemZzL3pm c19jdGxkaXIuYwkod29ya2luZyBjb3B5KQpAQCAtMTE0OSw2ICsxMTQ5LDcgQEAKIAkgICAg TlVMTCwgTlVMTCk7CiAJc2RwID0gdnAtPnZfZGF0YTsKIAlzZHAtPnpjX2NtdGltZSA9ICgo emZzY3RsX25vZGVfdCAqKXB2cC0+dl9kYXRhKS0+emNfY210aW1lOworCVZPUF9VTkxPQ0so dnAsIDApOwogCXJldHVybiAodnApOwogCiB9Cg== --------------050904040905030901040700--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009140820.o8E8K6Cx056610>