Date: Tue, 31 Jul 2001 09:43:03 -0600 From: Warner Losh <imp@harmony.village.org> To: Shizuka Kudo <shizukakudo_99@yahoo.com> Cc: mobile@freebsd.org Subject: Re: Better patches Message-ID: <200107311543.f6VFh3w49545@harmony.village.org> In-Reply-To: Your message of "Tue, 31 Jul 2001 03:50:37 PDT." <20010731105037.47206.qmail@web11401.mail.yahoo.com> References: <20010731105037.47206.qmail@web11401.mail.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20010731105037.47206.qmail@web11401.mail.yahoo.com> Shizuka Kudo writes: : Warner, : Looking at your patch pcic-stable.diff.14a, : : Your pcic_pci_attach() has the following lines : + sc->bst = sp->bst = rman_get_bustag(sc->memres); : + sc->bst = sp->bsh = rman_get_bushandle(sc->memres); : : do you mean to have sc->bst assigned twice? or should : the second line be : : sc->bsh = sp->bsh = .... Yes. It looks like sc->bsh might not be used, but you are nonetheless correct. Wraner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200107311543.f6VFh3w49545>