Date: Fri, 27 Jun 2003 00:04:52 +0100 From: Ian Dowse <iedowse@maths.tcd.ie> To: "M. Warner Losh" <imp@bsdimp.com> Cc: current@FreeBSD.ORG Subject: Re: Heads up: checking in change to ata-card.c Message-ID: <200306270004.aa89273@salmon.maths.tcd.ie> In-Reply-To: Your message of "Thu, 26 Jun 2003 13:14:17 MDT." <20030626.131417.101814768.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20030626.131417.101814768.imp@bsdimp.com>, "M. Warner Losh" writes:
>Here's a better patch, basesd on wpaul's input. Bill, can you try it
>an see if it works for you? If so, i would be better to commit this
>one. If not, I'll work with you to fix it.
FYI, I have a no-name ("PCMCIA"/"CD-ROM") drive that also requires
failure of the second IO range to be made non-fatal. How about just
deleting the `else' clause as in the patch below? It seems that
this can only affect CD-ROM drives that were otherwise not working,
so it should be fairly safe.
Ian
Index: ata-card.c
===================================================================
RCS file: /dump/FreeBSD-CVS/src/sys/dev/ata/ata-card.c,v
retrieving revision 1.14
diff -u -r1.14 ata-card.c
--- ata-card.c 17 Jun 2003 12:33:53 -0000 1.14
+++ ata-card.c 26 Jun 2003 23:00:01 -0000
@@ -131,10 +131,6 @@
start + ATA_ALTOFFSET, ATA_ALTIOSIZE);
}
}
- else {
- bus_release_resource(dev, SYS_RES_IOPORT, rid, io);
- return ENXIO;
- }
/* allocate the altport range */
rid = ATA_ALTADDR_RID;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200306270004.aa89273>