Date: Wed, 20 Mar 2019 16:26:59 -0600 From: Alan Somers <asomers@freebsd.org> To: Pedro Giffuni <pfg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345350 - in head: . lib/libjail sbin/mount_fusefs sys/conf sys/fs/fuse sys/modules sys/modules/fuse sys/modules/fusefs Message-ID: <CAOtMX2iozFYwURLdVOBtWrpK4T%2Bxf-d_ap=nKYgP9Q_opvZmtw@mail.gmail.com> In-Reply-To: <605f0e65-3683-7a48-8ef2-fce3eda00449@FreeBSD.org> References: <201903202148.x2KLmiJr059285@repo.freebsd.org> <605f0e65-3683-7a48-8ef2-fce3eda00449@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 20, 2019 at 4:23 PM Pedro Giffuni <pfg@freebsd.org> wrote: > > > On 20/03/2019 16:48, Alan Somers wrote: > > Author: asomers > > Date: Wed Mar 20 21:48:43 2019 > > New Revision: 345350 > > URL: https://svnweb.freebsd.org/changeset/base/345350 > > > > Log: > > Rename fuse(4) to fusefs(4) > > > > This makes it more consistent with other filesystems, which all end in "fs", > > and more consistent with its mount helper, which is already named > > "mount_fusefs". > > > > Reviewed by: cem, rgrimes > > MFC after: 2 weeks > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D19649 > > > > Added: > > head/sys/modules/fusefs/ > > - copied from r345349, head/sys/modules/fuse/ > > Deleted: > > head/sys/modules/fuse/ > > Modified: > > head/UPDATING > > head/lib/libjail/jail.c > > head/sbin/mount_fusefs/mount_fusefs.c > > head/sys/conf/NOTES > > head/sys/conf/files > > head/sys/conf/options > > head/sys/fs/fuse/fuse.h > > head/sys/fs/fuse/fuse_file.c > > head/sys/fs/fuse/fuse_ipc.c > > head/sys/fs/fuse/fuse_main.c > > head/sys/fs/fuse/fuse_node.c > > head/sys/fs/fuse/fuse_vfsops.c > > head/sys/fs/fuse/fuse_vnops.c > > head/sys/modules/Makefile > > head/sys/modules/fusefs/Makefile > > > Hmm.. > > Not that it matters but you renamed the module, shouldn't you rename the > directory as well? > > We have sys/fs/{deadfs|devfs|ext2fs|fdescfs|fifofs|msdosfs| ... etcfs}. > > Cheers, > > Pedro. Technically it's not a requirement for the build, and my other reviewer requested that I don't just to reduce repo churn. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2iozFYwURLdVOBtWrpK4T%2Bxf-d_ap=nKYgP9Q_opvZmtw>