Date: Tue, 23 Aug 2005 10:17:58 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Tim Robbins <tjr@freebsd.org> Cc: FreeBSD-arch <freebsd-arch@freebsd.org> Subject: Re: New library: libpidfile. Message-ID: <20050823081758.GB47261@garage.freebsd.pl> In-Reply-To: <430A8F1A.6090607@freebsd.org> References: <20050822213028.GB4812@garage.freebsd.pl> <430A8F1A.6090607@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--QKdGvSO+nmPlgiQ/ Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 23, 2005 at 12:51:06PM +1000, Tim Robbins wrote: +> Pawel Jakub Dawidek wrote: +>=20 +> >I'd like to commit a small library for handling "pidfiles". +> This sounds like a good idea to me, but you might consider putting the f= unctionality in libutil instead of creating a separate library. If you look at the perforce logs, you'll see it was in libutil at first. While I like libutil for some single functions (I added humanize_number(3) in there), but I don't like putting there everything. In my first concept (when it was part of libutil) I allocated memory to store needed informations, because I didn't wanted to use preallocated memory (someone linking libutil doesn't have to use pidfile functionality). Now, when it is a small library I can use preallocated memory and eliminate one point of potential failure. It also now has 4 functions, which makes it a good candidate of small, nice, lightweight library:) --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --QKdGvSO+nmPlgiQ/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDCtu2ForvXbEpPzQRAo6iAKDcKPIkRn6EzdvQ4+odiKUgyW/emACg7KRG cAkpIhRfq9DdADBqpFABqVI= =rAE+ -----END PGP SIGNATURE----- --QKdGvSO+nmPlgiQ/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050823081758.GB47261>