Date: Fri, 09 Apr 2010 17:29:27 +0300 From: Andriy Gapon <avg@freebsd.org> To: Scott Long <scottl@samsco.org> Cc: arch@freebsd.org, Rick Macklem <rmacklem@uoguelph.ca> Subject: Re: (in)appropriate uses for MAXBSIZE Message-ID: <4BBF39C7.4050308@freebsd.org> In-Reply-To: <07A7155D-0836-4D8C-BCF4-70FC16C77B69@samsco.org> References: <4BBEE2DD.3090409@freebsd.org> <Pine.GSO.4.63.1004090941200.14439@muncher.cs.uoguelph.ca> <07A7155D-0836-4D8C-BCF4-70FC16C77B69@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 09/04/2010 16:52 Scott Long said the following: > > Storage drivers are insulated from the details of MAXBSIZE by GEOM honoring > the driver's advertised max-i/o-size attribute. What I see when I grep through the > sources are mostly uses in busdma attributes, which themselves probably came > via cut-n-paste from prior drivers. I can't come up with any explanation for that > which makes good design sense, so I'll agree that storage drivers shouldn't > reference MAXBSIZE. Should DFLTPHYS be used there? Or is there a better DMA-specific constant? Or, perhaps, each driver should just use its won private constant based on its hardware capabilities? -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BBF39C7.4050308>