Date: Fri, 08 Jun 2001 01:39:08 -0700 From: Peter Wemm <peter@wemm.org> To: obrien@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/savecore savecore.c Message-ID: <20010608083908.35F25380C@overcee.netplex.com.au> In-Reply-To: <20010608005244.A2317@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"David O'Brien" wrote: > On Thu, Jun 07, 2001 at 08:06:24PM -0700, Peter Wemm wrote: > > peter 2001/06/07 20:06:24 PDT > > > > Modified files: > > sbin/savecore savecore.c > > Log: > > 'int dumpsize; /* memory size in bytes */' is not good for machines > > with 2GB or more of ram. > > Shouldn't the "unsigned int" have been size_t or "long" as off_t is a > long on the Alpha. The variable is an 'int dumpsize' in the kernel. size_t or long are simply not big enough to hold it - it is in pages inside the kernel and we convert it to bytes inside savecore. I have been Brucified on this one, so expect some fixups soon. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010608083908.35F25380C>