Date: Fri, 23 Jan 2009 14:05:55 +0000 From: Andrew Brampton <brampton+freebsd-fs@gmail.com> To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@des.no>, freebsd-fs <freebsd-fs@freebsd.org> Subject: Re: Pseudofs and pfs_attr_t for non-process based files Message-ID: <d41814900901230605o7a65efb3m4b6b99e9b171f1b7@mail.gmail.com> In-Reply-To: <86iqo74ba1.fsf@ds4.des.no> References: <d41814900901181701n7928e40cv2aa1dc4dff582fda@mail.gmail.com> <868wp4pqwm.fsf@ds4.des.no> <d41814900901210937y390cdff3pf6a9551df2c4bcd3@mail.gmail.com> <86iqo74ba1.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--000e0cd1e02830babb046126e3cb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2009/1/22 Dag-Erling Sm=C3=B8rgrav <des@des.no>: > In procfs_attr(), the vap->va_[ug]id assignments are redundant, since at > this point pfs_getattr() has already done the exact same thing. The > rest of the patch is fine, modulo style issues which already existed in > my code. Here are both patches again, but only the procfs patch has changed. I have now removed the redundant code. thanks Andrew --000e0cd1e02830babb046126e3cb Content-Type: text/x-patch; charset=US-ASCII; name="pseudofs_vnops.patch" Content-Disposition: attachment; filename="pseudofs_vnops.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fqaxdwxo0 SW5kZXg6IHN5cy9mcy9wc2V1ZG9mcy9wc2V1ZG9mc192bm9wcy5jCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5 cy9mcy9wc2V1ZG9mcy9wc2V1ZG9mc192bm9wcy5jCShyZXZpc2lvbiAxODc0MTUpCisrKyBzeXMv ZnMvcHNldWRvZnMvcHNldWRvZnNfdm5vcHMuYwkod29ya2luZyBjb3B5KQpAQCAtMjI2LDE0ICsy MjYsMTcgQEAgcGZzX2dldGF0dHIoc3RydWN0IHZvcF9nZXRhdHRyX2FyZ3MgKnZhKQogCWlmIChw cm9jICE9IE5VTEwpIHsKIAkJdmFwLT52YV91aWQgPSBwcm9jLT5wX3VjcmVkLT5jcl9ydWlkOwog CQl2YXAtPnZhX2dpZCA9IHByb2MtPnBfdWNyZWQtPmNyX3JnaWQ7Ci0JCWlmIChwbi0+cG5fYXR0 ciAhPSBOVUxMKQotCQkJZXJyb3IgPSBwbl9hdHRyKGN1cnRocmVhZCwgcHJvYywgcG4sIHZhcCk7 Ci0JCVBST0NfVU5MT0NLKHByb2MpOwogCX0gZWxzZSB7CiAJCXZhcC0+dmFfdWlkID0gMDsKIAkJ dmFwLT52YV9naWQgPSAwOwogCX0KIAorCWlmIChwbi0+cG5fYXR0ciAhPSBOVUxMKQorCQllcnJv ciA9IHBuX2F0dHIoY3VydGhyZWFkLCBwcm9jLCBwbiwgdmFwKTsKKworCWlmKHByb2MgIT0gTlVM TCkKKwkJUFJPQ19VTkxPQ0socHJvYyk7CisKIAlQRlNfUkVUVVJOIChlcnJvcik7CiB9CiAK --000e0cd1e02830babb046126e3cb Content-Type: text/x-patch; charset=US-ASCII; name="procfs.patch" Content-Disposition: attachment; filename="procfs.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fqaxe4gq1 SW5kZXg6IHN5cy9mcy9wcm9jZnMvcHJvY2ZzLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2ZzL3Byb2Nm cy9wcm9jZnMuYwkocmV2aXNpb24gMTg3NDE1KQorKysgc3lzL2ZzL3Byb2Nmcy9wcm9jZnMuYwko d29ya2luZyBjb3B5KQpAQCAtOTksNyArOTksNiBAQCBwcm9jZnNfZG9jdXJwcm9jKFBGU19GSUxM X0FSR1MpCiBpbnQKIHByb2Nmc19hdHRyKFBGU19BVFRSX0FSR1MpCiB7Ci0JUFJPQ19MT0NLX0FT U0VSVChwLCBNQV9PV05FRCk7CiAKIAkvKiBYWFggaW5lZmZpY2llbnQsIHNwbGl0IGludG8gc2Vw YXJhdGUgZnVuY3Rpb25zICovCiAJaWYgKHN0cmNtcChwbi0+cG5fbmFtZSwgImN0bCIpID09IDAg fHwKQEAgLTExMiwxMSArMTExLDEyIEBAIHByb2Nmc19hdHRyKFBGU19BVFRSX0FSR1MpCiAJICAg IHN0cmNtcChwbi0+cG5fbmFtZSwgImZwcmVncyIpID09IDApCiAJCXZhcC0+dmFfbW9kZSA9IDA2 MDA7CiAKLQlpZiAoKHAtPnBfZmxhZyAmIFBfU1VHSUQpICYmIHBuLT5wbl90eXBlICE9IHBmc3R5 cGVfcHJvY2RpcikKLQkJdmFwLT52YV9tb2RlID0gMDsKKwlpZiAocCAhPSBOVUxMKSB7CisJCVBS T0NfTE9DS19BU1NFUlQocCwgTUFfT1dORUQpOwogCi0JdmFwLT52YV91aWQgPSBwLT5wX3VjcmVk LT5jcl91aWQ7Ci0JdmFwLT52YV9naWQgPSBwLT5wX3VjcmVkLT5jcl9naWQ7CisJCWlmICgocC0+ cF9mbGFnICYgUF9TVUdJRCkgJiYgcG4tPnBuX3R5cGUgIT0gcGZzdHlwZV9wcm9jZGlyKQorCQkJ dmFwLT52YV9tb2RlID0gMDsKKwl9CiAKIAlyZXR1cm4gKDApOwogfQo= --000e0cd1e02830babb046126e3cb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d41814900901230605o7a65efb3m4b6b99e9b171f1b7>