Date: Tue, 25 Jan 2005 16:39:44 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: "Jacques A. Vidrine" <nectar@FreeBSD.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sys_generic.c Message-ID: <86669.1106667584@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 25 Jan 2005 09:37:29 CST." <20050125153729.GF5662@lum.celabo.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20050125153729.GF5662@lum.celabo.org>, "Jacques A. Vidrine" writes: >On Tue, Jan 25, 2005 at 12:42:26PM +0300, Andrey Chernov wrote: >> On Tue, Jan 25, 2005 at 09:15:32AM +0000, Poul-Henning Kamp wrote: >> > sys/kern sys_generic.c >> > Log: >> > Previously a read of zero bytes got handled in devfs:vop_read() but I >> > missed that when the vnode bypass was introduced. >> > >> > Deal with zero length transfers before we even get to fo_ops->fo_read(). >> >> Please back it out. Zero bytes read may affect atime, now not. > >I do not think that a zero byte read should not affect atime. Explain to me then why open+mmap doesn't affect atime isn't a bigger problem ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86669.1106667584>