Date: Thu, 15 Apr 2010 08:56:23 +0300 From: Andriy Gapon <avg@freebsd.org> To: Xin LI <delphij@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r206640 - in stable/8/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common Message-ID: <4BC6AA87.40309@freebsd.org> In-Reply-To: <201004150120.o3F1KUPt043636@svn.freebsd.org> References: <201004150120.o3F1KUPt043636@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 15/04/2010 04:20 Xin LI said the following: > Author: delphij > Date: Thu Apr 15 01:20:30 2010 > New Revision: 206640 > URL: http://svn.freebsd.org/changeset/base/206640 > > Log: > MFC r205198: > > Merge OpenSolaris revision 8802:010b31dd4c53: > > 6773366 "zfs list" memory consumption can be further reduced > > PR: bin/144720 > Submitted by: mm I wonder why you haven't also included into this MFC the commit that fixes crash with user properties. I think it's not nice to MFC a change with a known bug without a fix. > + while (curr) { > + zfs_prop_t zfs_prop = zfs_name_to_prop(nvpair_name(curr)); > + nvpair_t *next = nvlist_next_nvpair(zhp->zfs_props, curr); > + > + if (props[zfs_prop] == B_FALSE) zfs_prop can be -1 here, remember? -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BC6AA87.40309>