Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Dec 2007 12:33:03 GMT
From:      pav@FreeBSD.org
To:        pgollucci@p6m7g8.com, pav@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org, pav@FreeBSD.org
Subject:   Re: ports/118307: www/mod_perl2: [PATCH]: fix WITHOUT_APRUTIL_THREADS=yes, minor pkg-list fix, portlint fix
Message-ID:  <200712161233.lBGCX33t034576@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
Synopsis: www/mod_perl2: [PATCH]: fix WITHOUT_APRUTIL_THREADS=yes, minor pkg-list fix, portlint fix

State-Changed-From-To: open->feedback
State-Changed-By: pav
State-Changed-When: Sun Dec 16 12:25:42 UTC 2007
State-Changed-Why: 
This patch does not cover the scenario where neither apr.h is present.
Can I suggest something like this instead?

-.if ${APACHE_VERSION} >= 21
+.if exists(${LOCALBASE}/include/apr-1/apr.h)
+APR_H=         ${LOCALBASE}/include/apr-1/apr.h
+.elif exists(${LOCALBASE}/include/apr/apr.h)
+APR_H=         ${LOCALBASE}/include/apr/apr.h
+.endif
+
+.if defined(APR_H)
+APR_HAS_THREADS!=      ${ECHO_CMD} `${GREP} -c 'APR_HAS_THREADS *1' ${APR_H}`
+.else
+APR_HAS_THREADS=       0
+.endif
+
+.if ${APR_HAS_THREADS} == 1
+MAN3+=         APR::ThreadMutex.3
 PLIST_SUB+=    THREADMUTEX=""
 .else
 PLIST_SUB+=    THREADMUTEX="@comment "



Responsible-Changed-From-To: freebsd-ports-bugs->pav
Responsible-Changed-By: pav
Responsible-Changed-When: Sun Dec 16 12:25:42 UTC 2007
Responsible-Changed-Why: 
Track

http://www.freebsd.org/cgi/query-pr.cgi?pr=118307



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712161233.lBGCX33t034576>