Date: Tue, 13 Jan 2015 10:48:16 -0500 From: Eric van Gyzen <eric@vangyzen.net> To: Lars Engels <lars.engels@0x20.net>, Allan Jude <allanjude@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] Display progress during getmemsize() so the kernel doesn't look like it hanged Message-ID: <54B53E40.1030903@vangyzen.net> In-Reply-To: <20150113091122.GK67556@e-new.0x20.net> References: <D0D89A8E.129518%rpokala@panasas.com> <54B35B36.4040504@freebsd.org> <20150113091122.GK67556@e-new.0x20.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/13/2015 04:11, Lars Engels wrote: > On Mon, Jan 12, 2015 at 12:27:18AM -0500, Allan Jude wrote: >> Is this feature still useful with memtest.tests=0? > This feature is useful for everyone who has it set to 1, if they know > about it or not. So it's a very useful feature. Agreed. Comments on the patch: The patch will divide by zero when PAGE_SIZE > 1 MiB. Maybe remove PAGES_PER_MB, and just use PAGES_PER_GB. Make it const, too. The "total" line is mostly redundant with the later messages regarding "real memory" and "avail memory". I suggest removing it. Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54B53E40.1030903>