Date: Sat, 21 Apr 2018 11:31:05 -0700 From: Eitan Adler <lists@eitanadler.com> To: "Jonathan T. Looney" <jtl@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332860 - head/sys/kern Message-ID: <CAF6rxgnjfbUgYAvmyYXCEQ92Y%2BVJ8JTP6P8ANkVTSsOBZnqWTw@mail.gmail.com> In-Reply-To: <201804211705.w3LH50Dk056339@repo.freebsd.org> References: <201804211705.w3LH50Dk056339@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 April 2018 at 10:05, Jonathan T. Looney <jtl@freebsd.org> wrote: > Author: jtl > Date: Sat Apr 21 17:05:00 2018 > New Revision: 332860 > URL: https://svnweb.freebsd.org/changeset/base/332860 > > Log: > When running with INVARIANTS, the kernel contains extra checks. However, > these assumptions may not hold true once we've panic'd. Therefore, the > checks hold less value after a panic. Additionally, if one of the checks > fails while we are already panic'd, this creates a double-panic which can > interfere with debugging the original panic. Rather than do this I'd rather we modify the invariants to more explicitly state under what conditions it holds. This might be something like KASSERT(!panic && ...) or KASSERT_NOT_IN_PANIC(...) or some other spelling. -- Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnjfbUgYAvmyYXCEQ92Y%2BVJ8JTP6P8ANkVTSsOBZnqWTw>