Date: Thu, 2 Apr 2009 12:58:15 +0100 From: Rui Paulo <rpaulo@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: =?UTF-8?Q?J=C4=99drzej_Kalinowski?= <kalinoj1@iem.pw.edu.pl>, freebsd-emulation@FreeBSD.org Subject: Re: qemu 0.10.1 PCAP networking on CURRENT Message-ID: <0FACAA06-8675-4793-B485-9F7229DDACD8@FreeBSD.org> In-Reply-To: <200903261249.00104.jkim@FreeBSD.org> References: <962f2e5dc273dac6f2a2aaf017763bb2@iem.pw.edu.pl> <200903261249.00104.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-1-520774333 Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable On 26 Mar 2009, at 16:48, Jung-uk Kim wrote: > [CC added] > > On Thursday 26 March 2009 04:55 am, J=C4=99drzej Kalinowski wrote: >> Hi, >> >> I'm working with latest qemu port (0.10.1) submitted by Juergen >> Lock. Pcap networking didn't work ok for me - it was terribly slow. >> >> I'm on a 8.0-CURRENT system, so I don't know if it is also the case >> in older releases. Nevertheless, if someone experiences similiar >> problems, you can try this patch - it helped me: > > --- (PATCH removed) --- > > libpcap 1.0.0 was imported few days ago but it didn't merge the > following local hack: > > = http://www.freebsd.org/cgi/cvsweb.cgi/src/contrib/libpcap/pcap.h.diff?r1=3D= 1.13;r2=3D1.14 > > Your patch is harmless but it should be fixed in pcap.h and/or > net/bpf.h properly not to step on each other unless the plan is to > add PCAP_DONT_INCLUDE_PCAP_BPF_H everywhere in our ports tree to get > FreeBSD-specific definitions. For example, the QEMU patch needs at > least two ioctl definitions to get it really working, i.e., > BIOCIMMEDIATE and BIOCFEEDBACK, which are only present in net/bpf.h. > In fact, pcap-bpf.c itself has a hack for AIX like this: > > #ifdef _AIX > > /* > * Make "pcap.h" not include "pcap/bpf.h"; we are going to include the > * native OS version, as we need "struct bpf_config" from it. > */ > #define PCAP_DONT_INCLUDE_PCAP_BPF_H > > #include <sys/types.h> > > /* > * Prevent bpf.h from redefining the DLT_ values to their > * IFT_ values, as we're going to return the standard libpcap > * values, not IBM's non-standard IFT_ values. > */ > #undef _AIX > #include <net/bpf.h> > #define _AIX > > ... > > #else /* _AIX */ > > #include <net/bpf.h> > > #endif /* _AIX */ > > This is absolutely disgusting. IMHO, I don't think it is a good idea > to pollute ports tree with local patches like that. Sorry for the late reply. You're right that this is a miss on my side. =20= I'll fix it. Sorry, -- Rui Paulo --Apple-Mail-1-520774333 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAknUqFcACgkQfD8M/ASTygKKNQCaA/lebd2rFgNQy1uQx6NEstcI bZcAn324/hwozWdEHbkT/B4LNG50pdt6 =8a0V -----END PGP SIGNATURE----- --Apple-Mail-1-520774333--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0FACAA06-8675-4793-B485-9F7229DDACD8>