Date: Mon, 23 Feb 2004 21:12:10 -0500 From: Christopher Nehren <apeiron@comcast.net> To: Erwin Lansing <erwin@FreeBSD.org>, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/62166: Add the Shell::Base Perl module. Message-ID: <20040224021210.GA92172@prophecy.dyndns.org> In-Reply-To: <200402231843.i1NIhark032477@freefall.freebsd.org> References: <200402231843.i1NIhark032477@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nFreZHaLTZJo0R7j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Feb 23, 2004 at 13:43:36 EST, Erwin Lansing scribbled these
curious markings:
> Synopsis: Add the Shell::Base Perl module.
>=20
> State-Changed-From-To: open->feedback
> State-Changed-By: erwin
> State-Changed-When: Mon Feb 23 10:41:15 PST 2004
> State-Changed-Why:=20
> 'make test' fails with perl 5.005_03:
> t/version...........Global symbol "$PAGER" requires explicit package name=
at blib/lib/Shell/Base.pm line 760.
> Global symbol "$SHELL" requires explicit package name at blib/lib/Shell/B=
ase.pm line 869.
> Global symbol "$COLUMNS" requires explicit package name at blib/lib/Shell=
/Base.pm line 889.
>=20
> Do you know a way to fix this, or should it be marked for perl 5.6.x
> and up ?
>=20
> I added @dirrm %%SITE_PERL%%/Shell to pkg-plist, other from that,
> this looks good.
It seems that the 'use Env qw( ... )' line in Base.pm is what's causing
this. perl56delta states that Env.pm has changed to allow this to work
in 5.6.x onwards, while it breaks in 5.005. I don't have a machine
readily available with which to test this, but here's a diff against
Base.pm which should work:
--- Base.pm.orig Mon Feb 23 21:03:44 2004
+++ Base.pm Mon Feb 23 21:02:36 2004
@@ -16,7 +16,7 @@
);
use Carp qw(carp croak);
-use Env qw($PAGER $SHELL $COLUMNS);
+use Env qw(PAGER SHELL COLUMNS);
use IO::File;
use File::Basename qw(basename);
use Term::Size qw(chars);
Unfortunately, this causes t/signature to fail because of a broken
checksum. Here's a patch for that:
--- SIGNATURE.orig Mon Jan 5 18:12:11 2004
+++ SIGNATURE Mon Feb 23 21:06:31 2004
@@ -14,7 +14,7 @@
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
-SHA1 c941b31eea4980a6c9c77772ed7c9b686ef51d8a Base.pm
+SHA1 ec952ea398e416b8866f8dad9e2794b8745c1e12 Base.pm
SHA1 fd7a3bbc15b5e588bfbe5734d81e99e3369d001d Changes
SHA1 6773da3ad1af9e5bc9e53ca83703018b54fefbb4 MANIFEST
SHA1 c330e5c03d60d95c197e019f6d5a350b6642c3d6 META.yml
With these two patches, it should work with everything from 5.005 to
5.8.3 (which I have installed here, cf. ports/61444 :) ). Thanks for
working on this.
--=20
I abhor a system designed for the "user", if that word is a coded
pejorative meaning "stupid and unsophisticated". -- Ken Thompson
-
Unix is user friendly. However, it isn't idiot friendly.
-
Please CC me in all replies, even if I'm on the relevant list(s).
--nFreZHaLTZJo0R7j
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAOrL6k/lo7zvzJioRAgAqAKCxU5OFgyh971yvlykVMKlCdg7jTQCff3n1
YDfbh8DU5lHG1WOaGGq4ShU=
=WJnq
-----END PGP SIGNATURE-----
--nFreZHaLTZJo0R7j--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040224021210.GA92172>