Date: Sat, 9 Sep 2017 14:48:52 +0200 From: Hans Petter Selasky <hps@selasky.org> To: "Andrey V. Elsukov" <bu7cher@yandex.ru>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323351 - head/sys/compat/linuxkpi/common/include/linux Message-ID: <00d891a5-3fb7-5562-7f3d-645083779492@selasky.org> In-Reply-To: <1b752f11-2ec8-4c07-d53a-9e32a5fcf56c@yandex.ru> References: <201709090721.v897LRWA084296@repo.freebsd.org> <1b752f11-2ec8-4c07-d53a-9e32a5fcf56c@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/09/17 13:10, Andrey V. Elsukov wrote: > On 09.09.2017 10:21, Hans Petter Selasky wrote: >> Author: hselasky >> Date: Sat Sep 9 07:21:27 2017 >> New Revision: 323351 >> URL: https://svnweb.freebsd.org/changeset/base/323351 >> > > This doesn't look right. We use s6_addr16[1] to keep scope zone id. > And if_index value should be converted into network byte order. It is > quite usual to have more that 255 interfaces. > > And what is more important, you must not use this code for global IPv6 > addresses. > Hi, Thank you for your comments. This function is only used for interface specific addresses. Anyway, I'll make the requested changes! https://svnweb.freebsd.org/changeset/base/323364 --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?00d891a5-3fb7-5562-7f3d-645083779492>